-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat zero byte stream as a file. #551
Conversation
Treat zero byte stream as a file.
@diedmon could you add or enable unit test which reproduce the case a PR fixed? |
@miurahr I don't how to enable unit test, but I attached the test file in the attachment. |
Please put your test in test_archive.py/tests. You need to use |
Hi, @miurahr, thank you for your guide. I have updated the test_archive.py. |
|
Thank you for your comment, I have corrected the mistakes. |
Co-authored-by: Hiroshi Miura <miurahr@linux.com>
Thanks for your comment, I didn't realize that pytest can handle the exception properly without try and except. Also, please note that since a zero byte stream is treated as a file, it won't have the "emptystream" attribute anymore. |
Co-authored-by: Hiroshi Miura <miurahr@linux.com>
Co-authored-by: Hiroshi Miura <miurahr@linux.com>
Ref to issue #549 and issue #398. This pull request will fix those issues by treating zero byte stream as a file.