New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support union #42
Support union #42
Conversation
I can see there being utility in union types (although I personally would rarely use that feature), but I'm not sure if just passing through the value like this is the right way to go. Maybe if it's not an optional type we should require a |
I see I just said what you said, but less articulately. 😄 |
It looks like CI is failing because of Black checks. Once tests are passing this looks good to merge. We also need to update the documentation to explain how to use union types with some examples. I am happy to merge this as is though and create a new issue to track that. |
I ran Black on the code, I hope it will pass now. |
Thanks! |
This addresses #41 . It allows Union types again by simply removing the raising of the exception. I also handled 2 test that showcase the behavior.