Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataclass decorator #9

Merged
merged 1 commit into from Mar 14, 2021
Merged

dataclass decorator #9

merged 1 commit into from Mar 14, 2021

Conversation

adsharma
Copy link
Contributor

No description provided.

Copy link
Owner

@mivade mivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This looks fairly good as is but I think we want the included decorator to take the same arguments as the upstream one.

argparse_dataclass.py Outdated Show resolved Hide resolved
tests/example.py Show resolved Hide resolved
@adsharma
Copy link
Contributor Author

adsharma commented Mar 4, 2021

ping

@mivade
Copy link
Owner

mivade commented Mar 4, 2021

Sorry, I haven't had time to complete reviewing this yet. At a glance I think this looks fine but I want to test it out before merging.

@mivade
Copy link
Owner

mivade commented Mar 14, 2021

Sorry again for the delay. This looks good to me apart from some formatting issues. However since I don't have CI setup yet to automatically check those I'll merge and can update that later.

Thanks again for your contribution!

@mivade mivade merged commit 84d3918 into mivade:master Mar 14, 2021
@adsharma
Copy link
Contributor Author

adsharma commented Mar 14, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants