Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS Vulnerability Found #78

Closed
influxweb opened this issue Oct 17, 2019 · 0 comments · Fixed by #79
Closed

XSS Vulnerability Found #78

influxweb opened this issue Oct 17, 2019 · 0 comments · Fixed by #79
Assignees
Milestone

Comments

@influxweb
Copy link
Contributor

influxweb commented Oct 17, 2019

There is a global variable which adds a class to hide header and navigation elements when you are on a checkout page; this allows for the "distraction free" checkout process we introduced in Shadows. Unfortunately, the output of the variable is not entity-encoded which could open an page up for exploit.

Correcting the Issue

The quickest way to correct this issue is to install the Template Search and Replace Module, search for &mvt:global:checkout_hidden;, and replace it with &mvte:global:checkout_hidden; then search for &mvt:global:checkout_shown;, and replace it with &mvte:global:checkout_shown;. I have added this update and it will be included in the next maintenance release.

@influxweb influxweb added this to the v1.0.6 milestone Oct 17, 2019
@influxweb influxweb self-assigned this Oct 17, 2019
influxweb added a commit that referenced this issue Oct 18, 2019
This maintenance release addresses all issues contained in the v1.0.6 milestone.
https://github.com/mivaecommerce/readytheme-shadows/milestone/7?closed=1

This closes #68, closes #69, closes #70, closes #71, closes #72, closes #73, closes #74, closes #75, closes #76, closes #77, and closes #78
@influxweb influxweb mentioned this issue Oct 18, 2019
influxweb added a commit that referenced this issue Oct 18, 2019
This maintenance release addresses all issues contained in the v1.0.6 milestone.
https://github.com/mivaecommerce/readytheme-shadows/milestone/7?closed=1

This closes #68, closes #69, closes #70, closes #71, closes #72, closes #73, closes #74, closes #75, closes #76, closes #77, and closes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant