Merge pull request #472 from mivek/fix/EmptyWind

Fix/empty wind
mivek · Mar 12, 2023 · 91aa610 · 91aa610
2 parents 15c915c + d3546b0
commit 91aa610
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 8 deletions.
diff --git a/...Parser-parsers/src/main/java/io/github/mivek/command/common/MinimalVisibilityCommand.java b/...Parser-parsers/src/main/java/io/github/mivek/command/common/MinimalVisibilityCommand.java
@@ -10,7 +10,7 @@
  */
 public final class MinimalVisibilityCommand implements Command {
     /** Pattern for the minimum visibility. */
-    public static final Pattern MIN_VISIBILITY_REGEX = Pattern.compile("^(\\d{4}[a-zA-Z]{1,2})$");
+    public static final Pattern MIN_VISIBILITY_REGEX = Pattern.compile("^(\\d{4}[NnEeSsWw]{1,2})$");
 
     /**
      * Protected constructor.

diff --git a/metarParser-parsers/src/main/java/io/github/mivek/command/common/WindCommand.java b/metarParser-parsers/src/main/java/io/github/mivek/command/common/WindCommand.java
@@ -11,7 +11,7 @@
  */
 public final class WindCommand implements BaseWindCommand {
     /** Pattern regex for wind. */
-    private static final Pattern WIND_REGEX = Pattern.compile("^(VRB|[0-3]\\d{2})(\\d{2})G?(\\d{2})?(KT|MPS|KM/H)?");
+    private static final Pattern WIND_REGEX = Pattern.compile("^(VRB|00|[0-3]\\d{2})(\\d{2})G?(\\d{2})?(KT|MPS|KM/H)?");
 
     /**
      * Package private constructor.

diff --git a/metarParser-parsers/src/test/java/io/github/mivek/parser/MetarParserTest.java b/metarParser-parsers/src/test/java/io/github/mivek/parser/MetarParserTest.java
@@ -451,4 +451,15 @@ void testParseRunwayDeposit() {
         assertEquals("03 mm", m.getRunways().get(0).getThickness());
         assertEquals("friction coefficient of 0.35", m.getRunways().get(0).getBrakingCapacity());
     }
+
+    @Test
+    void testParsWithLowWind() {
+        String code = "KATW 022045Z 0000KT 10SM SCT120 00/M08 A2996";
+
+        Metar m = parser.parse(code);
+        assertEquals("KATW", m.getStation());
+        assertNotNull(m.getWind());
+        assertEquals(0, m.getWind().getSpeed());
+        assertEquals(0, m.getWind().getDirectionDegrees());
+    }
 }
diff --git a/pom.xml b/pom.xml
@@ -51,25 +51,25 @@
         <jacoco.coverage.branch.minimum>0.96</jacoco.coverage.branch.minimum>
         <jacoco.coverage.complexity.minimum>0.97</jacoco.coverage.complexity.minimum>
         <archunit-junit5.version>1.0.1</archunit-junit5.version>
-        <checkstyle.version>10.6.0</checkstyle.version>
+        <checkstyle.version>10.8.0</checkstyle.version>
         <commons-lang3.version>3.12.0</commons-lang3.version>
         <hamcrest.version>2.2</hamcrest.version>
         <jacoco-maven-plugin.version>0.8.8</jacoco-maven-plugin.version>
         <junit.version>5.9.2</junit.version>
         <maven-checkstyle-plugin.version>3.2.1</maven-checkstyle-plugin.version>
-        <maven-compiler-plugin.version>3.10.1</maven-compiler-plugin.version>
+        <maven-compiler-plugin.version>3.11.0</maven-compiler-plugin.version>
         <maven.gpg.plugin.version>3.0.1</maven.gpg.plugin.version>
         <maven.javadoc.plugin.version>3.4.1</maven.javadoc.plugin.version>
         <maven-project-info-reports-plugin.version>3.4.2</maven-project-info-reports-plugin.version>
         <maven-site-plugin.version>3.12.1</maven-site-plugin.version>
         <maven.source.plugin.version>3.2.1</maven.source.plugin.version>
-        <maven-surefire-plugin.version>3.0.0-M8</maven-surefire-plugin.version>
+        <maven-surefire-plugin.version>3.0.0-M9</maven-surefire-plugin.version>
         <nexus-staging-maven-plugin.version>1.6.13</nexus-staging-maven-plugin.version>
-        <commons-csv.version>1.9.0</commons-csv.version>
+        <commons-csv.version>1.10.0</commons-csv.version>
         <pitest-junit5-plugin.version>1.1.2</pitest-junit5-plugin.version>
-        <pitest-maven.version>1.10.4</pitest-maven.version>
+        <pitest-maven.version>1.11.3</pitest-maven.version>
         <slf4j-nop.version>2.0.6</slf4j-nop.version>
-        <spotbugs-maven-plugin.version>4.7.3.0</spotbugs-maven-plugin.version>
+        <spotbugs-maven-plugin.version>4.7.3.2</spotbugs-maven-plugin.version>
         <sonar.organization>mivek-github</sonar.organization>
         <sonar.host.url>https://sonarcloud.io</sonar.host.url>
     </properties>