Removed special handling to remove ":port" #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikeangstadt
commented
May 25, 2016
mikeangstadt
commented
- removed special handling to replace ":port" in req.headers.host as this.vhosts's keys will need to include port to be valid (so stripping port breaks any port specified vhost)
- Works fine without port specification as well, they just have to match.
- removed special handling to replace ":port" in req.headers.host as this.vhosts's keys will need to include port to be valid (so stripping port breaks any port specified vhost) * Works fine without port specification as well, they just have to match.
|
This is a breaking change and it will mess up apps that are not configured for it. |
|
mixdown-server@4.0.0 is published to npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.