increase code coverage

mixerapi · Jun 25, 2021 · d1e357a · d1e357a
1 parent df7bff2
commit d1e357a
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/src/Welcome.php b/src/Welcome.php
@@ -78,9 +78,7 @@ private function database()
             $errorMsg = $connectionError->getMessage();
             if (method_exists($connectionError, 'getAttributes')) {
                 $attributes = $connectionError->getAttributes();
-                if (isset($errorMsg['message'])) {
-                    $errorMsg .= '. ' . $attributes['message'];
-                }
+                $errorMsg .= $attributes['message'] ?? '';
             }
 
             return $errorMsg ?? 'unknown error / unable to connect';
@@ -159,13 +157,14 @@ private function whichMixerApiVersion(): string
         try {
             return InstalledVersions::getPrettyVersion('mixerapi/mixerapi');
         } catch (\Exception $e) {
+            try {
+                return InstalledVersions::getPrettyVersion('mixerapi/mixerapi-dev');
+            // the following should not be possible:
+            // @codeCoverageIgnoreStart
+            } catch (\Exception $e) {
+                throw new RuntimeException('Package mixerapi/mixerapi is not installed');
+            }
+            // @codeCoverageIgnoreEnd
         }
-
-        try {
-            return InstalledVersions::getPrettyVersion('mixerapi/mixerapi-dev');
-        } catch (\Exception $e) {
-        }
-
-        throw new RuntimeException('Package mixerapi/mixerapi is not installed');
     }
 }