Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of tildes for strikethourough should be two #12

Open
0x6b opened this issue Jan 4, 2019 · 0 comments · May be fixed by #27
Open

Number of tildes for strikethourough should be two #12

0x6b opened this issue Jan 4, 2019 · 0 comments · May be fixed by #27

Comments

@0x6b
Copy link

0x6b commented Jan 4, 2019

Hi @domchristie thank you very much for creating such a nice code. I used your turndown with my firefox add-on, copy-selection-as-markdown, and it works very well. Recently I found this plugin and tried to integrate with my add-on, then found a difference between your implementation and GFM spec.

According to GitHub Flavored Markdown Spec, strikethrough text should be wrapped in two tildes.

6.5 Strikethrough (extension)

GFM enables the strikethrough extension, where an additional emphasis type is available.

Strikethrough text is any text wrapped in two tildes (~).

But your implementation only adds one tilde as follows:

https://github.com/domchristie/turndown-plugin-gfm/blob/61a981b8c6aaec73bbb8a844d9f8686d0d5f066e/src/strikethrough.js#L5

Could you please have a look into the spec and give me your thought?

0x6b added a commit to 0x6b/copy-selection-as-markdown that referenced this issue Jan 9, 2019
- use my own strikethrough implementation at this moment
- update turndown-plugin-gfm if mixmark-io/turndown-plugin-gfm#12 will be fixed at upstream
@q00u q00u linked a pull request Oct 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant