Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring "theme colors" in presets #46

Closed
nikolasburk opened this issue Mar 26, 2019 · 3 comments
Closed

Allow configuring "theme colors" in presets #46

nikolasburk opened this issue Mar 26, 2019 · 3 comments
Labels
feature-request New feature or request

Comments

@nikolasburk
Copy link

The Carbon CLI is really awesome and I love that it's possible to store and reuse a configuration as preset. One thing I'd love to add to the config though is the actual "theme colors" (i.e. what color e.g. variables, operators, keywords, comments, ...).

Basically these options from the Carbon web UI:

Screenshot 2019-03-26 at 10 39 45

@mixn mixn added the feature-request New feature or request label Mar 26, 2019
@mixn
Copy link
Owner

mixn commented Mar 26, 2019

Hey @nikolasburk, thanks for chiming in and the nice words, much appreciated. Big fan of your work! :)

I’ve briefly dabbled with this idea since first seeing that these things are now configurable in the web UI.

First thought it might not be possible without doing some disgusting DOM traversing through Puppeteer, but just noticed all these values are stored in localStorage. :)

You’d likely lose the state/visuals by doing --open, but it should fully work through the CLI. 🤔

I’ll try and get to this soon. Quite swamped with work and conf season, but I’m eager to have it as part of the CLI. :)

@mixn mixn added the roadmap Likely to be implemented at some point label Apr 18, 2019
@mixn mixn removed the roadmap Likely to be implemented at some point label Nov 12, 2020
@raveling
Copy link

+1 🙇

@mixn mixn mentioned this issue Feb 6, 2023
26 tasks
@mixn
Copy link
Owner

mixn commented May 12, 2023

This feature ships with the official v2 release. 🙂

Documentation 🚀 for custom theme colors can be found here. 🙂

Happy testing and using! Looking forward to your feedback! @nikolasburk @raveling

P. S: I’m almost embarrassed about how long it took me to start working on v2, but at least once I did, I shipped it quite fast. 🙃 No more activity slumps in the future, though. 🤞

@mixn mixn closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants