Conditionally extend MAX_RANKs to 4-byte integer range for PostgreSQL #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAX_RANK_VALUE
andMIN_RANK_VALUE
are set to MySQL's 3-byte MEDIUMINT range by default. However, as PostgreSQL doesn't have a 3-byte integer data type and Postgres users are forced into allocating a 4-byte integer anyway, we may as well use the full 4-byte range to reduce the chance of potentially expensive rebalancing.For reference:
Signed 4-byte INTEGER in PostgreSQL: -2147483648 to +2147483647
Signed 3-byte MEDIUMINT in MySQL: -8388607 to +8388607
SQLite3 allocates space according to size of each value, so we'll stick with the defaults.