Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikeycgto among others.
This is an upgrade of RankedModel to support Rails 4 with all test passing. Notable is that this uses
database_cleaner
instead ofrspec-rails
to flush database records.This adds tests on Travis as well.
You can run the tests for a given version of Rails with:
Everything looks clean on travis and in the tests for this PR. I'll leave it open for a bit them merge and bump a gem version.
Huzzah Rails 4!