Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4 #46

Merged
merged 2 commits into from
Jul 3, 2013
Merged

Rails 4 #46

merged 2 commits into from
Jul 3, 2013

Conversation

mixonic
Copy link
Contributor

@mixonic mixonic commented Jul 1, 2013

@mikeycgto among others.

This is an upgrade of RankedModel to support Rails 4 with all test passing. Notable is that this uses database_cleaner instead of rspec-rails to flush database records.

This adds tests on Travis as well.

You can run the tests for a given version of Rails with:

ACTIVERECORD_VERSION="4.0.0" bundle update
ACTIVERECORD_VERSION="4.0.0" bundle exec rake

Everything looks clean on travis and in the tests for this PR. I'll leave it open for a bit them merge and bump a gem version.

Huzzah Rails 4!

@wilde4
Copy link

wilde4 commented Jul 2, 2013

Hi,

I have found an issue with Rails 4...

It looks like the with_same option is causing the issue.

In the model:
ranks :position, :with_same => :channel_id

When updating position the following error is thrown:
No field called "channel_id" found in model

mixonic added a commit that referenced this pull request Jul 3, 2013
@mixonic mixonic merged commit 8683040 into master Jul 3, 2013
@mixonic
Copy link
Contributor Author

mixonic commented Jul 3, 2013

@wilde4 see #47. I your issue may be related.

@chrisvariety
Copy link

Thanks @mixonic for 0.2.1! 🎆 🚀 ranked-model rocks.

@mjc-gh
Copy link
Contributor

mjc-gh commented Jul 11, 2013

woot!
On Jul 10, 2013 10:57 PM, "chrismcc" notifications@github.com wrote:

Thanks @mixonic https://github.com/mixonic for 0.2.1! [image:
🎆][image: 🚀] ranked-model rocks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/46#issuecomment-20787223
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants