enable tracking null property value

mixpanel · Apr 22, 2021 · 84c7ef2 · 84c7ef2
1 parent 5b25285
commit 84c7ef2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/androidTest/java/com/mixpanel/android/mpmetrics/MixpanelBasicTest.java b/src/androidTest/java/com/mixpanel/android/mpmetrics/MixpanelBasicTest.java
@@ -201,6 +201,7 @@ protected AnalyticsMessages getAnalyticsMessages() {
         JSONObject jsonObj2 = new JSONObject();
         JSONObject jsonObj3 = new JSONObject();
         JSONObject jsonObj4 = new JSONObject();
+        JSONObject jsonObj5 = new JSONObject();
         Map<String, Object> mapObj1 = new HashMap<>();
         Map<String, Object> mapObj2 = new HashMap<>();
         Map<String, Object> mapObj3 = new HashMap<>();
@@ -210,6 +211,7 @@ protected AnalyticsMessages getAnalyticsMessages() {
         jsonObj2.put("TRACK JSON INT", 1);
         jsonObj3.put("TRACK JSON STRING ONCE", "TRACK JSON STRING ONCE VALUE");
         jsonObj4.put("TRACK JSON STRING ONCE", "SHOULD NOT SEE ME");
+        jsonObj5.put("TRACK JSON NULL", JSONObject.NULL);
 
         mapObj1.put("TRACK MAP STRING", "TRACK MAP STRING VALUE");
         mapObj2.put("TRACK MAP INT", 1);
@@ -269,6 +271,12 @@ protected AnalyticsMessages getAnalyticsMessages() {
             assertEquals("event7", message.getString("event"));
             properties = message.getJSONObject("properties");
             assertFalse(properties.has("TRACK JSON STRING ONCE"));
+
+            mixpanel.track("event8", jsonObj5);
+            message = messages.poll(POLL_WAIT_SECONDS, TimeUnit.SECONDS);
+            assertEquals("event8", message.getString("event"));
+            properties = message.getJSONObject("properties");
+            assertEquals(jsonObj5.get("TRACK JSON NULL"), properties.get("TRACK JSON NULL"));
         } catch (InterruptedException e) {
             fail("Unexpected interruption");
         }

diff --git a/src/main/java/com/mixpanel/android/mpmetrics/MixpanelAPI.java b/src/main/java/com/mixpanel/android/mpmetrics/MixpanelAPI.java
@@ -2883,9 +2883,7 @@ protected void track(String eventName, JSONObject properties, boolean isAutomati
                 final Iterator<?> propIter = properties.keys();
                 while (propIter.hasNext()) {
                     final String key = (String) propIter.next();
-                    if (!properties.isNull(key)) {
-                        messageProps.put(key, properties.get(key));
-                    }
+                    messageProps.put(key, properties.get(key));
                 }
             }