Persist seen in-app campaign ids accross sessions #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchien
reviewed
Jun 21, 2017
| final SharedPreferences prefs = mLoadStoredPreferences.get(); | ||
| final SharedPreferences.Editor editor = prefs.edit(); | ||
| String campaignIds = prefs.getString("seen_campaign_ids", ""); | ||
| editor.putString("seen_campaign_ids", campaignIds + notificationId + DELIMITER); |
There was a problem hiding this comment.
lame there's no default serialization/deserialization
| mContext = context; | ||
| mToken = token; | ||
| mListener = listener; | ||
| mUpdatesFromMixpanel = updatesFromMixpanel; | ||
|
|
||
| mDistinctId = null; | ||
| mUnseenNotifications = new LinkedList<InAppNotification>(); | ||
| mNotificationIds = new HashSet<Integer>(); | ||
| mNotificationIds = new HashSet<Integer>(notificationIds); |
There was a problem hiding this comment.
is there a reason to make a copy here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in case there is no connectivity and the user opens up the app again later, the SDK will make sure we don't show the same in-app twice (i.e.
decidewon't know that the notification was seen until we flush again / connectivity is restored).