New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash prevention on getScaledScreenshot when rootView is not measured yet #729

Merged

zihejia merged 1 commit into mixpanel:master from matteinn:feature/#728-prevent-crash-on-getscaledscreenshot

Mar 25, 2021

Contributor

matteinn commented Mar 24, 2021

Fixes #728

Updated ActivityImageUtils.getScaledScreenshot(...) method like this:

Added a check on rootView width and height attributes to perform an early exit in case that view is not measured yet
Replaced the "// May return null." comment with a proper @nullable annotation so that the compiler will warn about improper nullability handling
Added a more explicit comment with reasons why this method may return null


          Crash prevention on getScaledScreenshot when rootView is not measured…

bce6a45

… yet

zihejia self-requested a review

March 25, 2021 03:27

zihejia approved these changes

View reviewed changes

Collaborator

zihejia left a comment

Thank you for providing this PR.

zihejia merged commit 8639aa2 into mixpanel:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment