Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setUseIpAddressForGeolocation, setEnableLogging, setServerURL #739

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

zihejia
Copy link
Collaborator

@zihejia zihejia commented Apr 28, 2021

Provide new apis, in parity with Mixpanel iOS SDK.
setUseIpAddressForGeolocation, setEnableLogging and setServerURL.

Previously, those settings are only available to be set in AndrodManifest.xml, not possible to be changed in run time and consumed by react-native/flutter SDK.

@zihejia zihejia force-pushed the config-api branch 3 times, most recently from e194aaf to 95dcb2e Compare April 28, 2021 22:23
Copy link
Collaborator

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zihejia zihejia merged commit f90201a into master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants