Upgrade targetSdkVersion to 30 #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zihejia
force-pushed
the
upgrade-target-sdk
branch
4 times, most recently
from
5bfd441
to
c2f6998
Compare
zihejia
changed the title
zihejia
force-pushed
the
upgrade-target-sdk
branch
from
c2f6998
to
abc0c3a
Compare
|
hi @jeorgearomal , because there will be no support from Google. Given the low adoption and the ongoing maintenance costs for us, we will bump the minSdkVersion soon but not this time(keep as is). In the future, after we upgrade minSdkVersion, if you still need to support lower minSdkVersion, you then have the option to use this version or any version before we upgrade minSdkVersion. Hope that helps! |
zihejia
force-pushed
the
upgrade-target-sdk
branch
2 times, most recently
from
e2d01f5
to
6719f8c
Compare
| compileSdkVersion 27 | ||
| buildToolsVersion '28.0.3' | ||
| compileSdkVersion 30 | ||
| buildToolsVersion '30.0.3' |
There was a problem hiding this comment.
the .0.3 happens to be same?
There was a problem hiding this comment.
it happens to be the same, it has to be a version exists, otherwise it won't build
There was a problem hiding this comment.
got it. just making sure .0.3 is the version we want here.
src/androidTest/java/com/mixpanel/android/mpmetrics/MixpanelBasicTest.java
Outdated
Show resolved
Hide resolved
src/androidTest/java/com/mixpanel/android/mpmetrics/OptOutTest.java
Outdated
Show resolved
Hide resolved
src/androidTest/java/com/mixpanel/android/mpmetrics/TestUtils.java
Outdated
Show resolved
Hide resolved
jaredmixpanel
approved these changes
Oct 6, 2021
zihejia
force-pushed
the
upgrade-target-sdk
branch
from
95c4c12
to
fe90b3a
Compare
zihejia
force-pushed
the
upgrade-target-sdk
branch
from
86497a9
to
0770f28
Compare
zihejia
force-pushed
the
upgrade-target-sdk
branch
from
0770f28
to
585810f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade targetSdkVersion to 30 to meet Google Play's target API level requirement by Nov 2021
#756