prefix device-specific distinct IDs with '$device:' #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zihejia
reviewed
Feb 22, 2023
| @@ -14,6 +14,7 @@ | |||
| import com.mixpanel.android.util.HttpService; | |||
| import com.mixpanel.android.util.RemoteService; | |||
|
|
|||
| import org.hamcrest.CoreMatchers; | |||
zihejia
reviewed
Feb 22, 2023
| @@ -1779,7 +1777,7 @@ public void identify(String distinctId) { | |||
| MPLog.e(LOGTAG, "Can't identify with null distinct_id."); | |||
| return; | |||
| } | |||
| if (distinctId != mPersistentIdentity.getEventsDistinctId()) { | |||
| if (!distinctId.equals(mPersistentIdentity.getEventsDistinctId())) { | |||
zihejia
reviewed
Feb 22, 2023
README.md
Outdated
| @@ -158,7 +158,7 @@ We'd also love for you to come and work with us! Check out our **[opening positi | |||
| <a name="changelog"></a> | |||
| # Changelog | |||
|
|
|||
| See [wiki page](https://github.com/mixpanel/mixpanel-android/wiki/Changelog). | |||
| See [wiki page](CHANGELOG.md). | |||
There was a problem hiding this comment.
Suggested change
| See [wiki page](CHANGELOG.md). | |
| See [changelog](CHANGELOG.md). |
|
Hey there, we just noticed that on AND, some distinct IDs have a "$device:" prefix. On iOS this is never the case. We are confused as to why this is the case? :D
|
|
@carstenhag mixpanel-swift started prefixing The Objective-C SDK started w/ v5.0.2: https://github.com/mixpanel/mixpanel-iphone/releases/tag/v5.0.2 Both were released 5 months ago. If you are using a version >= those, then I would recommend reaching out to support@mixpanel.com for help troubleshooting any identity management issues you're experiencing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.