Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support DateTime and Uri #66

Merged
merged 1 commit into from May 9, 2022

Conversation

amondnet
Copy link
Contributor

@amondnet amondnet commented Mar 7, 2022

Using DateTime and Uri will throw ArgumentError.

ArgumentError: Invalid argument: Instance of 'DateTime'

This pull request allows us to use dart DateTime and Uri.

_mixpanel.track("Track event with property", properties: {
                  "Cool Property": "Property Value",
                  "test": 233,
                  "complex": {
                    "child": [
                      {"deep1": "value1"},
                      {
                        "deep2": [1, 2]
                      }
                    ]
                  },
                  "date": DateTime.now(),
                  "uri": Uri.parse("https://mixpanel.com")
                })

Signed-off-by: Minsu Lee <amond@amond.net>
Copy link
Collaborator

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amondnet !

@jaredmixpanel jaredmixpanel added the enhancement New feature or request label May 9, 2022
@jaredmixpanel jaredmixpanel merged commit 3e68262 into mixpanel:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants