added fix for empty strings as cta urls #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ | |||
| #import "ViewController.h" | |||
|
|
|||
| // IMPORTANT!!! replace with you api token from https://mixpanel.com/account/ | |||
| #define MIXPANEL_TOKEN @"YOUR_MIXPANEL_PROJECT_TOKEN" | |||
| #define MIXPANEL_TOKEN @"metrics-1" | |||
| @@ -59,17 +59,19 @@ + (MPNotification *)notificationWithJSONObject:(NSDictionary *)object | |||
| } | |||
|
|
|||
| NSURL *callToActionURL = nil; | |||
| NSObject *URLString = object[@"cta_url"]; | |||
| NSString *URLString = object[@"cta_url"]; | |||
There was a problem hiding this comment.
I started calling this NSObject just to make clear that we don't know what type it is until we check isKindOfClass. But maybe its just more confusing and adds a ton of casts throughout the code. It can stay this way.
There was a problem hiding this comment.
I figured that if we went that route, we'd have to play the same way with all the other values we're parsing. It might actually merit its own pull request in the future.
gmorning
pushed a commit
to gmorning/mixpanel-iphone
that referenced
this pull request
Apr 28, 2020
…el#107) * persist identity in UserDefaults in case archive is corrupt. also some Xcode9 warning fixes * more xcode9 fixes and unit test for persistent identity * revert token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.