Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Expo SDK 44 build error #115

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Fix Expo SDK 44 build error #115

merged 1 commit into from
Jan 3, 2022

Conversation

Yonom
Copy link
Contributor

@Yonom Yonom commented Dec 18, 2021

Building our app which uses Expo SDK 44 (latest version) fails. This is because expo patches the react podspec for swift compatibility reasons and that causes old style imports to not work.

I fixed the issue by changing the import style.

More information: expo/expo#15622 (comment)

› Compiling mixpanel-react-native Pods/MixpanelReactNative » AutomaticProperties.swift

❌  (/Users/yonom/Documents/GitHub/app/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:424:1)

  422 |  * A class that allows NativeModules and TurboModules to look up one another.
  423 |  */
> 424 | @interface RCTModuleRegistry : NSObject
      | ^ duplicate interface definition for class 'RCTModuleRegistry'
  425 | - (void)setBridge:(RCTBridge *)bridge;
  426 | - (void)setTurboModuleRegistry:(id<RCTTurboModuleRegistry>)turboModuleRegistry;
  427 | 

@zihejia zihejia self-requested a review January 3, 2022 23:44
Copy link
Collaborator

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @Yonom!

@zihejia zihejia merged commit cdb9ac8 into mixpanel:master Jan 3, 2022
@Yonom Yonom deleted the fix-expo-44 branch January 4, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants