Returning Promise for the identify() to avoid race condition #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,13 +187,24 @@ export class Mixpanel { | |||
| * Mixpanel using the same disinct_id will be considered associated with the | |||
| * same visitor/customer for retention and funnel reporting, so be sure that the given | |||
| * value is globally unique for each individual user you intend to track. | |||
| * | |||
| * @returns {Promise} A promise that resolves when the identify is successful. | |||
| * It does not return any value. | |||
There was a problem hiding this comment.
Is this a breaking API change?
There was a problem hiding this comment.
it's still compatible with the old way of calling the api.
| resolver resolve: RCTPromiseResolveBlock, | ||
| rejecter reject: RCTPromiseRejectBlock) -> Void { | ||
| resolver resolve: @escaping RCTPromiseResolveBlock, | ||
| rejecter reject: @escaping RCTPromiseRejectBlock) -> Void { |
There was a problem hiding this comment.
Do we also need to update the Android side?
There was a problem hiding this comment.
android is a sync call so it should be fine
zihejia
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #147