New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue of passing boolean value as int in iOS #34

Merged

zihejia merged 2 commits into master from fix-bool-value-ios

Mar 18, 2021

Collaborator

zihejia commented Mar 18, 2021

In iOS bridge code, we should check whether it's passed as boolean originally from js code, a bit tricky in swift though.

zihejia added 2 commits

March 17, 2021 16:23


          fix the bool property being tracked as int type

0435ce3


          update yarn.lock

8ad4e25

zihejia requested a review from jaredmixpanel

March 18, 2021 00:05

jaredmixpanel approved these changes

View reviewed changes

Collaborator

jaredmixpanel left a comment

lgtm

zihejia merged commit 11e4be2 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment