Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new settings APIs(setUseIpAddressForGeolocation, setLoggingEnabled, setServerURL) #44

Merged
merged 3 commits into from
May 3, 2021

Conversation

zihejia
Copy link
Collaborator

@zihejia zihejia commented Apr 29, 2021

Provide new APIs, in parity with Mixpanel iOS and Android SDK.

  • setUseIpAddressForGeolocation,
  • setLoggingEnabled(add support for Anroid)
  • setServerURL (add support for Anroid)

Copy link
Collaborator

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zihejia zihejia force-pushed the add-more-apis branch 3 times, most recently from aff8b47 to e50af02 Compare May 3, 2021 21:51
@zihejia zihejia changed the title add new settings APIs add new settings APIs(setUseIpAddressForGeolocation, setEnableLogging, setServerURL) May 3, 2021
@zihejia zihejia changed the title add new settings APIs(setUseIpAddressForGeolocation, setEnableLogging, setServerURL) add new settings APIs(setUseIpAddressForGeolocation, setLoggingEnabled, setServerURL) May 3, 2021
@zihejia zihejia merged commit 34ddbbe into master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants