Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constructor method type definition #85

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Add constructor method type definition #85

merged 2 commits into from
Aug 23, 2021

Conversation

byeokim
Copy link
Contributor

@byeokim byeokim commented Aug 13, 2021

This solves the following TypeScript error addressed in #83:

const mixpanel = new Mixpanel("Your Project Token"); // Expected 0 arguments, but got 1.

@zihejia zihejia self-requested a review August 17, 2021 23:35
@zihejia
Copy link
Collaborator

zihejia commented Aug 23, 2021

Thank you @byeokim for contributing this PR!

@zihejia zihejia added the bug Something isn't working label Aug 23, 2021
@zihejia zihejia merged commit 8b3ee14 into mixpanel:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihejia zihejia zihejia approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@byeokim @zihejia