Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import to use a block to configure the http post #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jshow
Copy link

@jshow jshow commented Dec 11, 2018

For discussion, no tests written as yet - the branch is working for my purposes presently

Background

Import is broken. #106

The MixPanel import api requires the API SECRET to be passed in basic authentication

This PR adds a configuration block to the HTTP Post object, so basic_auth can be configured through a block

in host app config/initializers/mixpanel.rb

Mixpanel.config_http_request do |http_request|
  http_request.basic_auth "#{ENV['MIXPANEL_API_SECRET']}", ''
end

@andrewpurcell
Copy link
Contributor

Hi @jshow, thanks for opening this PR. We can't respond immediately but we'll get back to you after we investigate.

@DataGreed
Copy link

@andrewpurcell that's quite a long investigation you conduct, guys. Really long for a paid service.

@reinaris
Copy link

@andrewpurcell any change to have a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants