Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift fixes #106

Merged
merged 1 commit into from Jul 13, 2017
Merged

swift fixes #106

merged 1 commit into from Jul 13, 2017

Conversation

yarneo
Copy link
Contributor

@yarneo yarneo commented Jul 13, 2017

this fixes the crash we have been seeing with the UITabSwappableImageView.
this also fixes the modification of existing a/b tests.

pchien
pchien approved these changes Jul 13, 2017
View reviewed changes
Copy link

@pchien pchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. do you know if modifying ab tests is an issue on obj c as well?

@yarneo
Copy link
Contributor Author

yarneo commented Jul 13, 2017

Just tested it with Obj-C, seems like it's an issue there as well. I'll open a PR for it.

@yarneo yarneo merged commit b8e2556 into master Jul 13, 2017
@zihejia zihejia deleted the swift-fixes branch January 26, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchien pchien pchien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yarneo @pchien