Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DEVELOPMENT_BUILD build flag instead of Debug.isDebugBuild #167

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Use DEVELOPMENT_BUILD build flag instead of Debug.isDebugBuild #167

merged 1 commit into from
Feb 27, 2024

Conversation

elic-sightful
Copy link
Contributor

Debug.isDebugBuild is not thread-safe, it can only be run in Unity's main thread.
A build flag could be used instead and set at build time

@elic-sightful
Copy link
Contributor Author

@zihejia Could you take a look at this PR? 🙏

zihejia
zihejia approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @elic-sightful!

@zihejia zihejia merged commit ca784dd into mixpanel:master Feb 27, 2024
@zihejia zihejia added the bug label Feb 27, 2024
@elic-sightful elic-sightful deleted the fix-debug-threads branch February 28, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihejia zihejia zihejia approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elic-sightful @zihejia