Eslintify panel #35
Eslintify panel #35
Conversation
lib/isorender/dom-shims.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| /* global global */ | |||
There was a problem hiding this comment.
Shouldn't this be eslint-env node?
test/server/dom-patcher.js
Outdated
| @@ -1,3 +1,5 @@ | |||
| /* eslint-env mocha */ | |||
| /* eslint-disable no-unused-expressions */ | |||
There was a problem hiding this comment.
What are the unused expressions it's complaining about?
There was a problem hiding this comment.
expect(domPatcher.el).to.be.ok;
it isn't ok with to.be.ok
| @@ -1,8 +1,7 @@ | |||
| import cuid from 'cuid'; | |||
| import pick from 'lodash.pick'; | |||
test/fixtures/attr-reflection-app.js
Outdated
|
|
||
| export class AttrReflectionApp extends Component { | ||
| get config() { | ||
| return { | ||
| template: state => h('div', {class: {'attr-app': true}}, [ | ||
| h('p', `Value of attribute wombats: ${this.getAttribute('wombats')}`), | ||
| // eslint-disable-next-line no-unused-vars |
There was a problem hiding this comment.
It's just a test fixture, might as well make it conform with template: () => h(...) (ditto for the other fixtures below)
|
Not creating a new release since there is no change in build. |
|
Did you actually check the build files against the current release? I don't see how they could have stayed the same, with the removal of the lodash import. |
|
you are right. I was assuming a git status change would have shown a change in build. My bad, publishing a patched version |
|
No change in
builddir. Mostly syntactic sugar.