Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor correction regarding float positioning #5

Merged
merged 1 commit into from Feb 3, 2016
Merged

Conversation

sumbach
Copy link
Contributor

@sumbach sumbach commented Feb 2, 2016

Floats are positioned from the outside in, so the second right-floated box is to the left of the first.

@mixu I know you know this; I suspect this is a copy-paste issue or minor error introduced when changing the example to float: right instead of left.

✨ Thanks for this awesome resource!! Even as an experienced front-end developer, this taught me a lot (and gave me a better mental model to think about styling and layout) ✨

@mixu
Copy link
Owner

mixu commented Feb 3, 2016

hi @sumbach! I'm glad to hear that you found the book helpful and sorry for all the various mistakes! I'll go ahead and merge them in next.

A bit of backstory on the book: I actually wrote the whole thing as a response to a couple of CSS interviews where I failed. I realized I knew a bunch of recipes for achieving specific layouts and tips and tricks that I had picked up along the way but not what the spec said or why exactly things worked the way they do. So I spent about four months figuring out and writing up all the details 😄

Thanks for taking the time to submit corrections for all of these!

mixu added a commit that referenced this pull request Feb 3, 2016
Minor correction regarding float positioning
@mixu mixu merged commit fca4944 into mixu:master Feb 3, 2016
@sumbach sumbach deleted the patch-2 branch February 3, 2016 12:35
@sumbach
Copy link
Contributor Author

sumbach commented Feb 3, 2016

hi @sumbach! I'm glad to hear that you found the book helpful and sorry for all the various mistakes! I'll go ahead and merge them in next.

No need to apologize--thank you for creating and awesome resource for the community, and thank for you allowing me to contribute in some small way 😆

A bit of backstory on the book: I actually wrote the whole thing as a response to a couple of CSS interviews where I failed. I realized I knew a bunch of recipes for achieving specific layouts and tips and tricks that I had picked up along the way but not what the spec said or why exactly things worked the way they do. So I spent about four months figuring out and writing up all the details

I love it!! Such an inspiration to hear how you used a frustrating experience to motivate you.

Thanks for taking the time to submit corrections for all of these!

Any time 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants