Debug a segfault on electron 0.33.7

mixu · Oct 12, 2015 · 0be0574 · 0be0574
1 parent 6c4016b
commit 0be0574
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,3 @@
 node_modules/
 *.png
 .DS_Store
-
diff --git a/bin/shot.js b/bin/shot.js
@@ -55,7 +55,7 @@ function runElectron() {
     if (typeof argv[key] !== 'boolean') {
       return all.concat([ '--' + key,  argv[key] ]);
     } else {
-      return all.concat('--' + (argv[key] ? 'no-' : ''));
+      return all.concat('--' + (argv[key] ? 'no-' : '') + key);
     }
   }, []));
 

diff --git a/electron/run-tasks.js b/electron/run-tasks.js
@@ -1,4 +1,5 @@
 var fs = require('fs'),
+    os = require('os'),
     path = require('path');
 
 var ipc = require('ipc'),
@@ -14,7 +15,8 @@ module.exports = function(tasks) {
       if (i === 0) {
         mainWindow = new BrowserWindow({
           show: true,
-          'enable-larger-than-screen': true,
+          // SEGFAULTS on linux (!) with Electron 0.33.7 (!!)
+          'enable-larger-than-screen': (os.platform() !== 'linux'),
           'skip-taskbar': true,
           'use-content-size': true,
           // resizable: false,

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "electroshot",
   "version": "1.0.0",
-  "description": "# Features",
+  "description": "Capture website screenshots (with web fonts!) using Electron",
   "main": "test.js",
   "scripts": {
     "test": "mocha -R spec --bail ./test/*.test.js"

diff --git a/readme.md b/readme.md
@@ -1,4 +1,6 @@
-# screenshot
+# electroshot
+
+Capture website screenshots (with web fonts!) using Electron.
 
 # Features