Add qtkeychain 0.9.1 support to Linux/macOS build. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
force-pushed
the
qtkeychain_unix
branch
3 times, most recently
from
d36e9b1
to
cefa3ad
Compare
|
Ok This finally works. I think we can merge this because it is also used for master builds. |
rryan
reviewed
Aug 28, 2018
rryan
changed the title
daschuer
force-pushed
the
qtkeychain_unix
branch
from
51f8785
to
bae901e
Compare
Conflicts: scripts/macosx/build_environment.sh
|
Merge? |
rryan
reviewed
Sep 15, 2018
rryan
reviewed
Sep 15, 2018
scripts/macosx/build_qtkeychain.sh
Outdated
| popd > /dev/null | ||
|
|
||
| export VERSION_NUMBER=0.9.1 | ||
| export QT_VERSION=5.10.1 |
Conflicts: scripts/linux-ubuntu/pbuilderrc
|
Can one have a look? |
|
test this please |
|
@Pegasus-RPG cleared up disk space a few days ago, so I think it should build now. |
Be-ing
reviewed
Sep 17, 2018
scripts/macosx/build_environment.sh
Outdated
| @@ -16,6 +16,7 @@ MIXXX_MACOSX_SDK=$(xcodebuild -version -sdk macosx SDKVersion) | |||
| # Qt 5.11 requires a minimum of macOS 10.11. | |||
| MIXXX_MACOSX_TARGET='10.11' | |||
| MIXXX_MACOSX_STDLIB='libc++' | |||
| MIXXX_QT_VERSION='5.10.1' | |||
There was a problem hiding this comment.
Please rebase this to use Qt 5.11.1
daschuer
force-pushed
the
qtkeychain_unix
branch
from
3cf53e4
to
1f32e35
Compare
|
Ready:-) |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the successor of #49 updated to qtkeychain 0.9.1
Fixes #40.