Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new controls from saved loop feature #231

Merged
merged 8 commits into from
Nov 6, 2020

Conversation

Holzhaus
Copy link
Member

This adds documentation for the new controls added by PR mixxxdj/mixxx#2194.

@Holzhaus Holzhaus added this to In progress in 2.4 via automation Oct 17, 2020
@Holzhaus Holzhaus changed the base branch from manual-2.3.x to main October 29, 2020 23:23
@Holzhaus Holzhaus marked this pull request as ready for review November 4, 2020 22:15
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
the loop "type" control is missing.

source/chapters/advanced_topics.rst Outdated Show resolved Hide resolved
source/chapters/advanced_topics.rst Outdated Show resolved Hide resolved
source/chapters/advanced_topics.rst Outdated Show resolved Hide resolved
source/chapters/advanced_topics.rst Outdated Show resolved Hide resolved
source/chapters/advanced_topics.rst Outdated Show resolved Hide resolved
source/chapters/advanced_topics.rst Outdated Show resolved Hide resolved
source/chapters/advanced_topics.rst Outdated Show resolved Hide resolved
source/chapters/advanced_topics.rst Outdated Show resolved Hide resolved
source/chapters/advanced_topics.rst Outdated Show resolved Hide resolved
@@ -1402,11 +1491,15 @@ Any control listed above for :mixxx:cogroupref:`[ChannelN]` will work for a samp

Doubles :mixxx:coref:`beatloop_size <[ChannelN],beatloop_size>`. If :mixxx:coref:`beatloop_size <[ChannelN],beatloop_size>` equals the size of the loop, the loop is resized.

If a saved loop is currently enabled, the modification is saved to the hotcue slot immediately.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware, that this will destroy a saved loop if the you exit it using the loop having effect.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand you you mean. Can you rephrase?

Copy link
Member

@daschuer daschuer Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just aware of the following:

Sometimes I enable a loop in the outro, bring in the new track in and the shrink the loop by having it, before if fade out the last track.

This "destroyes" my original saved loop.
This is nothing new with normal loops, but for this use case saved loops are currently useless.

I wonder how competitors do it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serato has a concept of "locked" loops that don't have this behavior.

2.4 automation moved this from In progress to Review in progress Nov 5, 2020
@Holzhaus
Copy link
Member Author

Holzhaus commented Nov 5, 2020

Thank you.
the loop "type" control is missing.

Done.

@daschuer
Copy link
Member

daschuer commented Nov 6, 2020

Link check fails.

@Holzhaus
Copy link
Member Author

Holzhaus commented Nov 6, 2020

Link check fails.

Unrelated, see #285.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, than let's merge.

2.4 automation moved this from Review in progress to Reviewer approved Nov 6, 2020
@daschuer daschuer merged commit beb81df into mixxxdj:main Nov 6, 2020
2.4 automation moved this from Reviewer approved to Done Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.4
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants