Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traktor S3 #308

Merged
merged 46 commits into from Feb 16, 2021
Merged

Traktor S3 #308

merged 46 commits into from Feb 16, 2021

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Nov 18, 2020

Add manual page for the Traktor Kontrol S3

Holzhaus
Holzhaus requested changes Nov 18, 2020
View reviewed changes
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
@ywwg
Copy link
Member Author

ywwg commented Nov 18, 2020

notes addressed

@ywwg
Copy link
Member Author

ywwg commented Nov 18, 2020

sphinx failures appear not to be my problem (errors in other files)

Holzhaus
Holzhaus requested changes Nov 18, 2020
View reviewed changes
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
@ywwg
Copy link
Member Author

ywwg commented Nov 18, 2020

notes addressed

@ywwg ywwg requested a review from Holzhaus November 19, 2020 03:11
@ywwg
Copy link
Member Author

ywwg commented Nov 21, 2020

notes addressed again

@ywwg ywwg requested a review from Be-ing November 21, 2020 15:46
Holzhaus
Holzhaus requested changes Nov 21, 2020
View reviewed changes
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated Show resolved Hide resolved
@ywwg @Holzhaus
Update source/hardware/controllers/native_instruments_traktor_kontrol…
4be4a64 
…_s3.rst

Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
@Be-ing
Copy link
Contributor

Be-ing commented Dec 8, 2020

I don't see anything about how the pad grid works.

@Holzhaus Holzhaus mentioned this pull request Dec 16, 2020
Merged
@ywwg
Copy link
Member Author

ywwg commented Feb 15, 2021

I don't see anything about how the pad grid works.

added

@Be-ing
Copy link
Contributor

Be-ing commented Feb 15, 2021

Did you forget to push?

@ywwg
Copy link
Member Author

ywwg commented Feb 15, 2021

I wish github would let me queue up my replies so I could push and reply at the same time lol. I was still working

@Be-ing
Copy link
Contributor

Be-ing commented Feb 16, 2021 

 Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:180: WARNING: Unexpected indentation.

Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:182: WARNING: Block quote ends without a blank line; unexpected unindent.
Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:185: WARNING: Enumerated list ends without a blank line; unexpected unindent.

@Holzhaus
Copy link
Member

Btw, both the manual and the website repo have a pre-commit config that let's you check these kinds of issues when committing.

ywwg and others added 5 commits February 15, 2021 21:57
@ywwg @Be-ing
Update source/hardware/controllers/native_instruments_traktor_kontrol…
d75a6da 
…_s3.rst


call it a "limited effects" controller

Co-authored-by: Be <be.0@gmx.com>
@ywwg @Be-ing
Update source/hardware/controllers/native_instruments_traktor_kontrol…
4ea5264 
…_s3.rst


Traktor S3: commit suggestion

Co-authored-by: Be <be.0@gmx.com>
@ywwg @Be-ing
Update source/hardware/controllers/native_instruments_traktor_kontrol…
06873b7 
…_s3.rst


Traktor S3: commit suggestion

Co-authored-by: Be <be.0@gmx.com>
@ywwg
Traktor S3: Clarify some effect lanugage
2fed307
@ywwg
Merge branch 'traktor-s3' of github.com:ywwg/manual into traktor-s3
93b3984
@Be-ing
Copy link
Contributor

Be-ing commented Feb 16, 2021 

 Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:218: WARNING: Title underline too short.

Effect Chain Edit Mode
~~~~~~~~~~~~~~~~~
Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:218: WARNING: Title underline too short.

Effect Chain Edit Mode
~~~~~~~~~~~~~~~~~

@ywwg ywwg requested a review from Be-ing February 16, 2021 16:44
@Be-ing Be-ing merged commit 80dd9fd into mixxxdj:2.3 Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoergAtGithub JoergAtGithub JoergAtGithub left review comments

@Holzhaus Holzhaus Awaiting requested review from Holzhaus

@Be-ing Be-ing Awaiting requested review from Be-ing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ywwg @Be-ing @Holzhaus @JoergAtGithub