-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusive language #393
Inclusive language #393
Conversation
Oops, this should go into main, we didn't rename the outputs in 2.3 yet. |
0be3ae5
to
781748e
Compare
hmm.. It's also rather inconsistent for the GUI documentation and in skins: I think we should add this to 2.3 --except maybe the sound hardware preferences documentation-- but the remaining skin labels can easily be adjusted for 2.3 (even with the label/tooltip inconsistency). |
Hmm, I think it would be confusing to talk about "Main output" if it's named "master output" in the preferences. I'm not particularily keen on splitting up this issue. If you think it's needed, please go ahead, otherwise let's just postpone it until 2.4. |
ah okay, I see mixxxdj/mixxx#3868 was merged to main because of String freeze. Side note: why should Master/Main be translated at all? I vaguely remember we discussed to not translate terms that are virtually omnipresent hardware labels on most DJ/audio gear. |
So, should we merge this into main? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, two small nitpicks, LGTM otherwise.
|
||
main output | ||
master output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe emphasize that the term "master output" has been used historically, but is being phased out so people will know which one to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest a wording? I'm a bit uncreative today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add an extra sentence at the end of the description like this:
Please note: the term "master output" has been used historically but is in the process of being phased out. Prefer using "main output".
I'm not too good at writing either so feel free to make changes as you see fit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much LGTM
I guess owen doesn't have any interest / time to review this so I'll go ahead and merge now. |
sorry I didn't have time to review. thanks for doing the work |
Following up on our commitment we made here: https://mixxx.org/news/2020-06-29-black-lives-matter/
This replaces the term "master" with "main", "master sync" with "sync lock", "sync master" with "sync leader". I did not replace occurences where I had the impression that it referred to a hardware label, as this would make it harder to find the corresponding button/fader.
This also fixes an actual issue because we already replaced the term in the GUI, but the old term was still used in the docs.