Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliased controls and move deprecated COs in separate section #579

Merged
merged 6 commits into from
Dec 29, 2023

Conversation

Holzhaus
Copy link
Member

No description provided.

@Holzhaus Holzhaus marked this pull request as ready for review September 17, 2023 15:04

.. mixxx:control:: [App],num_samplers

The number of samplers currently enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this value change when switching the skin? I think a mapping developer needs to know, if it's constant over the runtime of the mapping.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's constant, but I don't really know. I did not change the current description, just moved it into a new [App] section. If you have a new wording please make a suggestion and I'll include it. Otherwise this could be improved in a later PR (maybe file an issue).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the CO is adjusted to the maximum of

  • num_samplers set in skin manifest
  • samplers.xml loaded at startup
  • any other sampler bank XML loaded manually later on

:feedback: Main Gain knob

.. deprecated:: 2.0.0
Use :mixxx:coref:`[Master],gain` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess [master] is not correct here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, we did not rename that yet. I just moved it.

:feedback: Headphone Gain knob

.. deprecated:: 2.0.0
Use :mixxx:coref:`[Master],headGain` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess [master] is not correct here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, we did not rename that yet. I just moved it.


:range: binary
:feedback: Loop range in waveform activates or deactivates.
.. versionadded: 2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the versionadded directives are not showing up, seemingly treated as comments for some reason.

source/chapters/appendix/mixxx_controls.rst Show resolved Hide resolved
@JoergAtGithub
Copy link
Member

Let's merge this now - mapping developers need to know, what's the actual syntax to be used. Thank you!

@JoergAtGithub JoergAtGithub merged commit fd1c6b2 into mixxxdj:2.4 Dec 29, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants