-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
/
trackmetadata_test.cpp
267 lines (258 loc) · 12.7 KB
/
trackmetadata_test.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
#include <gtest/gtest.h>
#include "track/trackrecord.h"
class TrackMetadataTest : public testing::Test {
};
TEST_F(TrackMetadataTest, parseArtistTitleFromFileName) {
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" only - title ", false);
EXPECT_EQ(QString(), trackInfo.getArtist());
EXPECT_EQ("only - title", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" artist-title ", true);
EXPECT_EQ("artist", trackInfo.getArtist());
EXPECT_EQ("title", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" artist -_title ", true);
EXPECT_EQ("artist", trackInfo.getArtist());
EXPECT_EQ("_title", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" only - title.mp3", false);
EXPECT_EQ(QString(), trackInfo.getArtist());
EXPECT_EQ("only - title", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" artist - title ", true);
EXPECT_EQ("artist", trackInfo.getArtist());
EXPECT_EQ("title", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" ar.tist -\tti.tle\t.mp3", true);
EXPECT_EQ("ar.tist", trackInfo.getArtist());
EXPECT_EQ("ti.tle", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" -artist - -title-.mp3", true);
EXPECT_EQ("-artist", trackInfo.getArtist());
EXPECT_EQ("-title-", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" -artist ti-tle- ", true);
EXPECT_EQ(QString(), trackInfo.getArtist());
EXPECT_EQ("-artist ti-tle-", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" artist- title ", true);
EXPECT_EQ("artist", trackInfo.getArtist());
EXPECT_EQ("title", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" artist- ", true);
EXPECT_EQ("artist", trackInfo.getArtist());
EXPECT_EQ(QString(), trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" -title ", true);
EXPECT_EQ(QString(), trackInfo.getArtist());
EXPECT_EQ("title", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" - artist__-__title - ", true);
EXPECT_EQ("- artist_", trackInfo.getArtist());
EXPECT_EQ("_title -", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" - only__-__title_-_", true);
EXPECT_EQ(QString(), trackInfo.getArtist());
EXPECT_EQ("- only__-__title_-_", trackInfo.getTitle());
}
{
mixxx::TrackInfo trackInfo;
trackInfo.parseArtistTitleFromFileName(" again - only_-_title _ ", true);
EXPECT_EQ(QString(), trackInfo.getArtist());
EXPECT_EQ("again - only_-_title _", trackInfo.getTitle());
}
}
TEST_F(TrackMetadataTest, mergeImportedMetadata) {
// Existing track metadata (stored in the database) without extra properties
mixxx::TrackRecord oldTrackRecord;
mixxx::TrackMetadata* pOldTrackMetadata = oldTrackRecord.ptrMetadata();
pOldTrackMetadata->setBitrate(mixxx::audio::Bitrate(100));
pOldTrackMetadata->setChannelCount(mixxx::audio::ChannelCount(1));
pOldTrackMetadata->setDuration(mixxx::Duration::fromSeconds(60));
pOldTrackMetadata->setSampleRate(mixxx::audio::SampleRate(10000));
mixxx::TrackInfo* pOldTrackInfo = pOldTrackMetadata->ptrTrackInfo();
pOldTrackInfo->setArtist("old artist");
pOldTrackInfo->setBpm(mixxx::Bpm(100));
pOldTrackInfo->setComment("old comment");
pOldTrackInfo->setComposer("old composer");
pOldTrackInfo->setGenre("old genre");
pOldTrackInfo->setGrouping("old grouping");
pOldTrackInfo->setKey("1A");
pOldTrackInfo->setReplayGain(mixxx::ReplayGain(0.1, 1));
pOldTrackInfo->setTitle("old title");
pOldTrackInfo->setTrackNumber("1");
pOldTrackInfo->setTrackTotal("10");
pOldTrackInfo->setYear("2001-01-01");
mixxx::AlbumInfo* pOldAlbumInfo = pOldTrackMetadata->ptrAlbumInfo();
pOldAlbumInfo->setArtist("old album artist");
pOldAlbumInfo->setTitle("old album title");
// Imported track metadata (from file tags) with extra properties
mixxx::TrackMetadata newTrackMetadata;
newTrackMetadata.setBitrate(mixxx::audio::Bitrate(200));
newTrackMetadata.setChannelCount(mixxx::audio::ChannelCount(2));
newTrackMetadata.setDuration(mixxx::Duration::fromSeconds(120));
newTrackMetadata.setSampleRate(mixxx::audio::SampleRate(20000));
mixxx::TrackInfo* pNewTrackInfo = newTrackMetadata.ptrTrackInfo();
pNewTrackInfo->setArtist("new artist");
pNewTrackInfo->setBpm(mixxx::Bpm(200));
pNewTrackInfo->setComment("new comment");
pNewTrackInfo->setComposer("new composer");
#if defined(__EXTRA_METADATA__)
pNewTrackInfo->setConductor("new conductor");
pNewTrackInfo->setDiscNumber("1");
pNewTrackInfo->setDiscTotal("2");
pNewTrackInfo->setEncoder("encoder");
pNewTrackInfo->setEncoderSettings("encoder settings");
#endif // __EXTRA_METADATA__
pNewTrackInfo->setGenre("new genre");
pNewTrackInfo->setGrouping("new grouping");
#if defined(__EXTRA_METADATA__)
pNewTrackInfo->setISRC("isrc");
#endif // __EXTRA_METADATA__
pNewTrackInfo->setKey("1A");
#if defined(__EXTRA_METADATA__)
pNewTrackInfo->setLanguage("language");
pNewTrackInfo->setLyricist("lyricist");
pNewTrackInfo->setMood("mood");
pNewTrackInfo->setMovement("movement");
pNewTrackInfo->setMusicBrainzArtistId(QUuid("11111111-1111-1111-1111-111111111111"));
pNewTrackInfo->setMusicBrainzRecordingId(QUuid("22222222-2222-2222-2222-222222222222"));
pNewTrackInfo->setMusicBrainzReleaseId(QUuid("33333333-3333-3333-3333-333333333333"));
pNewTrackInfo->setMusicBrainzWorkId(QUuid("44444444-4444-4444-4444-444444444444"));
pNewTrackInfo->setRemixer("remixer");
#endif // __EXTRA_METADATA__
pNewTrackInfo->setReplayGain(mixxx::ReplayGain(0.2, 2));
pNewTrackInfo->setTitle("new title");
pNewTrackInfo->setTrackNumber("2");
pNewTrackInfo->setTrackTotal("20");
#if defined(__EXTRA_METADATA__)
pNewTrackInfo->setWork("work");
#endif // __EXTRA_METADATA__
pNewTrackInfo->setYear("2002-02-02");
mixxx::AlbumInfo* pNewAlbumInfo = newTrackMetadata.ptrAlbumInfo();
pNewAlbumInfo->setArtist("new album artist");
#if defined(__EXTRA_METADATA__)
pNewAlbumInfo->setCopyright("copyright");
pNewAlbumInfo->setLicense("license");
pNewAlbumInfo->setMusicBrainzArtistId(QUuid("55555555-5555-5555-5555-555555555555"));
pNewAlbumInfo->setMusicBrainzReleaseGroupId(QUuid("66666666-6666-6666-6666-666666666666"));
pNewAlbumInfo->setMusicBrainzReleaseId(QUuid("77777777-7777-7777-7777-777777777777"));
pNewAlbumInfo->setRecordLabel("copyright");
pNewAlbumInfo->setReplayGain(mixxx::ReplayGain(0.3, 3));
#endif // __EXTRA_METADATA__
pNewAlbumInfo->setTitle("new album title");
mixxx::TrackRecord mergedTrackRecord = oldTrackRecord;
ASSERT_EQ(mergedTrackRecord.getMetadata(), oldTrackRecord.getMetadata());
ASSERT_NE(newTrackMetadata, *pOldTrackMetadata);
mergedTrackRecord.mergeImportedMetadata(newTrackMetadata);
mixxx::TrackMetadata* pMergedTrackMetadata = mergedTrackRecord.ptrMetadata();
EXPECT_EQ(pOldTrackMetadata->getBitrate(), pMergedTrackMetadata->getBitrate());
EXPECT_EQ(pOldTrackMetadata->getChannelCount(), pMergedTrackMetadata->getChannelCount());
EXPECT_EQ(pOldTrackMetadata->getDuration(), pMergedTrackMetadata->getDuration());
EXPECT_EQ(pOldTrackMetadata->getSampleRate(), pMergedTrackMetadata->getSampleRate());
mixxx::TrackInfo* pMergedTrackInfo = pMergedTrackMetadata->ptrTrackInfo();
EXPECT_EQ(pOldTrackInfo->getArtist(), pMergedTrackInfo->getArtist());
EXPECT_EQ(pOldTrackInfo->getBpm(), pMergedTrackInfo->getBpm());
EXPECT_EQ(pOldTrackInfo->getComment(), pMergedTrackInfo->getComment());
EXPECT_EQ(pOldTrackInfo->getComposer(), pMergedTrackInfo->getComposer());
#if defined(__EXTRA_METADATA__)
EXPECT_EQ(pNewTrackInfo->getConductor(), pMergedTrackInfo->getConductor());
EXPECT_EQ(pNewTrackInfo->getDiscNumber(), pMergedTrackInfo->getDiscNumber());
EXPECT_EQ(pNewTrackInfo->getDiscTotal(), pMergedTrackInfo->getDiscTotal());
EXPECT_EQ(pNewTrackInfo->getEncoder(), pMergedTrackInfo->getEncoder());
EXPECT_EQ(pNewTrackInfo->getEncoderSettings(), pMergedTrackInfo->getEncoderSettings());
#endif // __EXTRA_METADATA__
EXPECT_EQ(pOldTrackInfo->getGenre(), pMergedTrackInfo->getGenre());
EXPECT_EQ(pOldTrackInfo->getGrouping(), pMergedTrackInfo->getGrouping());
#if defined(__EXTRA_METADATA__)
EXPECT_EQ(pNewTrackInfo->getISRC(), pMergedTrackInfo->getISRC());
#endif // __EXTRA_METADATA__
EXPECT_EQ(pOldTrackInfo->getKey(), pMergedTrackInfo->getKey());
#if defined(__EXTRA_METADATA__)
EXPECT_EQ(pNewTrackInfo->getLanguage(), pMergedTrackInfo->getLanguage());
EXPECT_EQ(pNewTrackInfo->getLyricist(), pMergedTrackInfo->getLyricist());
EXPECT_EQ(pNewTrackInfo->getMood(), pMergedTrackInfo->getMood());
EXPECT_EQ(pNewTrackInfo->getMovement(), pMergedTrackInfo->getMovement());
EXPECT_EQ(pNewTrackInfo->getMusicBrainzArtistId(), pMergedTrackInfo->getMusicBrainzArtistId());
EXPECT_EQ(pNewTrackInfo->getMusicBrainzRecordingId(),
pMergedTrackInfo->getMusicBrainzRecordingId());
EXPECT_EQ(pNewTrackInfo->getMusicBrainzReleaseId(),
pMergedTrackInfo->getMusicBrainzReleaseId());
EXPECT_EQ(pNewTrackInfo->getMusicBrainzWorkId(),
pMergedTrackInfo->getMusicBrainzWorkId());
EXPECT_EQ(pNewTrackInfo->getRemixer(), pMergedTrackInfo->getRemixer());
#endif // __EXTRA_METADATA__
EXPECT_EQ(
pOldTrackInfo->getReplayGain(), pMergedTrackInfo->getReplayGain());
EXPECT_EQ(pOldTrackInfo->getTitle(), pMergedTrackInfo->getTitle());
EXPECT_EQ(pOldTrackInfo->getTrackNumber(),
pMergedTrackInfo->getTrackNumber());
EXPECT_EQ(
pOldTrackInfo->getTrackTotal(), pMergedTrackInfo->getTrackTotal());
#if defined(__EXTRA_METADATA__)
EXPECT_EQ(pNewTrackInfo->getWork(), pMergedTrackInfo->getWork());
#endif // __EXTRA_METADATA__
EXPECT_EQ(pOldTrackInfo->getYear(), pMergedTrackInfo->getYear());
mixxx::AlbumInfo* pMergedAlbumInfo =
pMergedTrackMetadata->ptrAlbumInfo();
EXPECT_EQ(pOldAlbumInfo->getArtist(), pMergedAlbumInfo->getArtist());
#if defined(__EXTRA_METADATA__)
EXPECT_EQ(pNewAlbumInfo->getCopyright(), pMergedAlbumInfo->getCopyright());
EXPECT_EQ(pNewAlbumInfo->getLicense(), pMergedAlbumInfo->getLicense());
EXPECT_EQ(pNewAlbumInfo->getMusicBrainzArtistId(),
pMergedAlbumInfo->getMusicBrainzArtistId());
EXPECT_EQ(pNewAlbumInfo->getMusicBrainzReleaseGroupId(),
pMergedAlbumInfo->getMusicBrainzReleaseGroupId());
EXPECT_EQ(pNewAlbumInfo->getMusicBrainzReleaseId(),
pMergedAlbumInfo->getMusicBrainzReleaseId());
EXPECT_EQ(pNewAlbumInfo->getRecordLabel(), pMergedAlbumInfo->getRecordLabel());
EXPECT_EQ(pNewAlbumInfo->getReplayGain(), pMergedAlbumInfo->getReplayGain());
#endif // __EXTRA_METADATA__
EXPECT_EQ(pOldAlbumInfo->getTitle(), pMergedAlbumInfo->getTitle());
// Check that all existing properties are preserved, even if empty or missing
pMergedTrackInfo->setArtist("");
pMergedTrackInfo->setTitle(QString());
pMergedAlbumInfo->setArtist("");
pMergedAlbumInfo->setTitle(QString());
mergedTrackRecord.mergeImportedMetadata(newTrackMetadata);
EXPECT_EQ(QString(""), pMergedTrackInfo->getArtist());
EXPECT_EQ(QString(), pMergedTrackInfo->getTitle());
EXPECT_EQ(QString(""), pMergedAlbumInfo->getArtist());
EXPECT_EQ(QString(), pMergedAlbumInfo->getTitle());
// Check that the placeholder for track total is replaced with the actual property
ASSERT_NE(mixxx::TrackRecord::kTrackTotalPlaceholder, pNewTrackInfo->getTrackTotal());
pMergedTrackInfo->setTrackTotal(mixxx::TrackRecord::kTrackTotalPlaceholder);
mergedTrackRecord.mergeImportedMetadata(newTrackMetadata);
EXPECT_EQ(pNewTrackInfo->getTrackTotal(), pMergedTrackInfo->getTrackTotal());
// ...but if track total is missing entirely it should be preserved
ASSERT_NE(QString(), pNewTrackInfo->getTrackTotal());
pMergedTrackInfo->setTrackTotal(QString());
mergedTrackRecord.mergeImportedMetadata(newTrackMetadata);
EXPECT_EQ(QString(), pMergedTrackInfo->getTrackTotal());
}