Windows MSIs built with CMake do not install MSVC runtime

[mixxxbot]

Reported by: Be-ing
Date: 2020-08-09T18:24:42Z
Status: Fix Released
Importance: Critical
Launchpad Issue: lp1890955

---

Installing a build from http://downloads.mixxx.org/builds/appveyor/cmake_build/?C=M;O=D on a new Windows VM, Mixxx installs but when trying to run it, it fails with a popup showing this error:

The code execution could not proceed because MSVCP140.dll was not found. Reinstalling the program may fix this problem.

After clicking OK on that dialog, another one appears:

The code execution cannot proceed because VCRUNTIME140.dll was not found. Reinstalling the program may fix this problem.

After installing the MSVC runtime separately, Mixxx starts successfully.

[mixxxbot]

Commented by: uklotzde
Date: 2020-08-09T20:35:50Z

---

Didn't we upgrade the build VM to MSVC 2017 (15.0)? Then MSVC 2015 (14.0) are the wrong redistributables.

[mixxxbot]

Commented by: uklotzde
Date: 2020-08-09T20:37:28Z

---

This could also be the reason for the failing 2.3.0 WiX builds.

[mixxxbot]

Commented by: Be-ing
Date: 2020-08-09T20:50:34Z

---

These are not built with our build server; they are built with AppVeyor.

[mixxxbot]

Commented by: uklotzde
Date: 2020-08-09T21:11:30Z

---

On AppVeyor we also use the "Visual Studio 2017" image.

[mixxxbot]

Commented by: uklotzde
Date: 2020-08-09T21:48:20Z

---

Sorry for the confusion, Microsoft versioning. At least the buildserver seems to bundle the correct versions into 2.3-j00019-x86-release-fastbuild-static-55e94982-minimal.zip according to build_environment.log:

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Redist\MSVC\14.15.26706\vc_redist.x64.exe
1 File(s) copied
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Redist\MSVC\14.15.26706\vc_redist.x86.exe
1 File(s) copied

The SDK version is still 14, while the internal MSVC version is 15.

[mixxxbot]

Commented by: uklotzde
Date: 2020-08-09T21:50:43Z

---

https://docs.microsoft.com/cpp/porting/binary-compat-2015-2017

[mixxxbot]

Commented by: Be-ing
Date: 2020-08-09T22:05:48Z

---

Are you confusing this with Bug #⁠1814273? That was with the legacy SCons build. This bug is about CMake. The CMake builds do not package any version of the MSVC runtime.

[mixxxbot]

Commented by: uklotzde
Date: 2020-08-09T22:37:03Z

---

I didn't notice that we already have a bug for the redistributable versioning issue. Added a note there.

[mixxxbot]

Commented by: JosepMaJAZ
Date: 2020-08-12T17:33:54Z

---

Correct.

It is a pending task to regenerate the CMake installer with all that the Scons script did, which includes generating multilanguage installer (which require a cumbersome multi-installer generation) and the generation of the exe installer that was a container of both, the runtime and mixxx installers.

And we might include visual studio 2017 or 2019 runtime now ( the are all downward compatible to 2015). If we include 2017, we will probably need some workaround precisely for the bug reported on that bug #⁠1814273 .

[mixxxbot]

Commented by: Be-ing
Date: 2020-09-11T23:04:27Z

---

#3084

[mixxxbot]

Issue closed with status Fix Released.