-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library scrolling very slow with cover art column showing #10223
Comments
Commented by: ronso0 Can you still verify with 2.4? |
Commented by: daschuer I have just updated my productive system to 2.4 (latest main), but I need to downgrade right away because of this issue. Really a 2.4 blocker for me. I am currently on Ubuntu Focal 20.04 LTS. |
Commented by: uklotzde Does not affect Fedora 34. |
Commented by: uklotzde I have increased the debounce timeout to 1 sec, because the default doesn't work for me. But even the default doesn't make Mixxx unusable. |
Commented by: daschuer The debounce time is at 287 ms. I have just set it to 1000 ms, but the scrolling issue remains unchanged. By the way, unusable is a too hard term literally. It just hampers me in my normal workflow in a way that I prefer to use 2.3. Do you have an idea what make has happened that creates the delay? After changing the debounce time to 1000 Ms I have noticed another issue with the debounce time itself:
A workaround would be to wait the debounce time again before refreshing the cover arts. Maybe this is a workaround for the scrolling issue as well, before we have found the root cause. |
Commented by: uklotzde Please also consider that the cover art hashes need to be re-calculated once after upgrading to 2.4. |
Commented by: daschuer Yes! The issue is "fixed" when disabling the cover-art column. |
Commented by: Be-ing Is this bug still reproducible? |
Commented by: foss-4 I think yes. Explanation was given by Uwe https://bugs.launchpad.net/mixxx/+bug/1905124/comments/8 This is a one time process. So should this bug be set to wontfix as mixxx is behaving as intended? Maybe a hint about this should be added to the release notes? |
Commented by: daschuer Yes, that is the mayor issue not to switch to 2.4 branch of my productive setup. |
Commented by: foss-4 From my understanding, re-population of hash database is a one time process after which scrolling performance is then restored. This is not uncommon in software development. Not sure I would call this a regression. But clearly this needs to be communicated to users, so that they can make an informed decision. Maybe instead of only mentioning this change in changelog, a dialog could be displayed offering to rehash covers for entire library with options
Maybe we can also come up with better text, this is just to share the idea. |
Commented by: foss-4 And re: scrolling performance - there is a critical macOS qt bug opened 2019 Jan with recent activity: Bug: https://bugreports.qt.io/browse/QTBUG-73117 Really hope the qt team will be able to address this. |
Commented by: Be-ing We may consider backporting that Qt patch to our vcpkg builds. |
Commented by: daschuer The issue is a redundant cover lookup in the main thread after a cover has been discovered without a cover digest. It is a one time issue, but if you have many files in the database it happens many times during a performance. |
fixed by #4904 |
Reported by: daschuer
Date: 2020-11-21T11:37:48Z
Status: In Progress
Importance: High
Launchpad Issue: lp1905124
Tags: library, performance
In the current Mixxx
2.4.0
alphapre-0ubuntu1mastergit7574~bionicI can no longer scroll continuously through the library.
During Entering a search phrase Mixxx gets stuck and the keystrokes are buffered and appears only after a few seconds.
This makes Mixxx unusable for using Live.
My setup uses a internal spinning HD for library and files connected via S-ATTA.
Mixxx 2.3-beta is not affected.
I did not notice it before, because on my development machine I have only a few tracks and a internal SSD.
The text was updated successfully, but these errors were encountered: