Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distorsion when moving rate slider + Rubberband #10270

Open
mixxxbot opened this issue Aug 23, 2022 · 9 comments
Open

Distorsion when moving rate slider + Rubberband #10270

mixxxbot opened this issue Aug 23, 2022 · 9 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2021-01-03T22:07:41Z
Status: New
Importance: Undecided
Launchpad Issue: lp1909938


Rubberband seems to reset it's internal filter when changing the rate. This leads to a hear-able distortion.

You can hear it best using a 440 Hz Test file.

The alternative would be to use a second Rubberband and crossfade to the new one whenever the rate changes. Unfortunately we cannot effort the extra CPU for this. The solution must be implemented CPU friendly inside Rubberband

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-01-03T22:10:27Z


Tested with 1.8.1-7ubuntu2 on Ubuntu Bionic

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-01-03T22:16:13Z


It looks like something has changed upstream in a not yet released version:
https://hg.sr.ht/~breakfastquay/rubberband/rev/6c0f84bf30b336be7b5424fbf0d5f55a05cbdbdd
https://hg.sr.ht/~breakfastquay/rubberband/rev/74a8a12b8d3c6aab9df129a4b310941b95ffb3e1

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-01-03T22:19:47Z


https://todo.sr.ht/~breakfastquay/rubberband/6

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-01-04T10:18:49Z


The linked bug affects the speex resampler. We use libsamplerate.

breakfastquay/rubberband#30

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-04-08T12:02:51Z


Fedora used the default build settings which defaults to speex for resampling although libsamplerate would be available.

PR: https://src.fedoraproject.org/rpms/rubberband/pull-request/1

@mixxxbot
Copy link
Collaborator Author

Commented by: eeickmeyer
Date: 2021-04-08T14:01:19Z


Thank you for taking the time to report this bug and helping to make Ubuntu better. Please execute the following command only once, as it will automatically gather debugging information, in a terminal:
apport-collect 1909938

When reporting bugs in the future please use apport by using 'ubuntu-bug' and the name of the package affected. You can learn more about this functionality at https://wiki.ubuntu.com/ReportingBugs.

-Additionally-

The issue you are reporting is an upstream one and it would be nice if somebody having it could send the bug to the developers of the software by following the instructions at https://wiki.ubuntu.com/Debian/Bugs.

If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about its status. Thanks in advance.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-04-09T23:07:27Z


I have executed "apport-collect 1909938" and it ends with "No additional info collected"
Are you still missing info?

This is the upstream bug:
breakfastquay/rubberband#30

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-04-09T23:18:01Z


And:
https://todo.sr.ht/~breakfastquay/rubberband/11

@mixxxbot
Copy link
Collaborator Author

Commented by: eeickmeyer
Date: 2021-04-10T00:27:43Z


Those aren't the bug reports that "upstream" is referring to here. Please report this bug to Debian using the instructions previously provided (https://wiki.ubuntu.com/Debian/Bugs). The package originates from Debian, from which Ubuntu derives.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant