Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPM sorting doesn't respect the decimal point #10292

Closed
mixxxbot opened this issue Aug 23, 2022 · 7 comments
Closed

BPM sorting doesn't respect the decimal point #10292

mixxxbot opened this issue Aug 23, 2022 · 7 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: c-moon
Date: 2021-01-17T20:44:34Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1912112
Tags: library
Attachments: [BPM sorting with decimal point](https://bugs.launchpad.net/bugs/1912112/+attachment/5453962/+files/BPM sorting with decimal point)


If you sort the music library by BPM, it seems that it only sorts integers in hierarchical order, but not the values after the decimal point (see attached picture).

Tested with recent commit 7e52e3b (Gentoo Linux x86_64, Qt 5.15.2).

Regards,
Marco

@mixxxbot
Copy link
Collaborator Author

Commented by: c-moon
Date: 2021-01-17T20:44:34Z
Attachments: [BPM sorting with decimal point](https://bugs.launchpad.net/mixxx/+bug/1912112/+attachment/5453962/+files/BPM sorting with decimal point)

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-03-02T13:16:23Z


confirmed, also in https://mixxx.discourse.group/t/2-3-bpm-sorting-issue/21512

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-03-02T23:35:30Z


This is a regression since 2.2.4 and should be fixed before release.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-03-02T23:41:48Z


Fixing it before releasing 2.3.0 would be nice, but I don't think it should block the release if it comes to that. Fixing it in 2.3.1 would be okay.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-03-03T00:47:01Z


#3669

@mixxxbot
Copy link
Collaborator Author

Commented by: c-moon
Date: 2021-03-04T10:10:21Z


I've just compiled and tested the latest commit 6a56345 => works as expected. Thanks for fixing this issue in 2.3.0, guys!

Regards,

Marco

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant