Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Better Support for DDJ-SX2 #10330

Open
mixxxbot opened this issue Aug 23, 2022 · 5 comments
Open

Feature Request: Better Support for DDJ-SX2 #10330

mixxxbot opened this issue Aug 23, 2022 · 5 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: l-mail-3
Date: 2021-02-22T14:18:36Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1916492


Hi!

I'm a lucky owner use of a Pioneer DDJ-SX2 and using the "DDJ-SX" Midi Binding for it.
Most of the features work fine out of the box, but I noticed 2 things:

  1. The Wheel does not animate, when the track is played.
  2. The Colors of the pads are all in lightblue

Since the DDJ-SX(1) does not have multi color pads, maybe it would make sense to create a own controller support file called "DDJ-SX2" derived from the DDJ-SX, which supports multi color pads?

With version 2.3 of mixxx this would perfectly fit to the Hot Cue Colors.

I have also tried this mapping: https://github.com/tildearrow/Mixxx-Pioneer-DDJ-SX2
It creates different colors for cue points, but not corresponding with the label color
Also the wheel animation does work with this binding.
But unfortunately other things doesn't work so well. :(

I can give it a try to extend the "DDJ-SX", maybe I get things working?
Because the rest works pretty fine. And wiki Doku is also fine.

@mixxxbot
Copy link
Collaborator Author

Commented by: l-mail-3
Date: 2021-02-23T08:57:07Z


Would it be a good thing to extend the current Midi binding Pioneer-DDJ-SX-scripts.js / Pioneer DDJ-SX.midi.xml? Or would it be better to have a copy of the code?

If it is somehow possible to ask for the device name "DDJ-SX2", I could extend the needed parts without affecting the original parts.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-02-23T16:05:00Z


I suggest to fork the DDJ-SX script and add the SX2-specific features. When you are done, if someone with an original DDJ-SX tests it and it works fine, we can rename the SX2 mapping for SX/SX2 and delete the old code.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-02-23T16:05:54Z


https://github.com/mixxxdj/mixxx/wiki/Contributing-Mappings

Start by copying the files for the DDJ-SX and renaming them.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@Krafting
Copy link

Hello, I have a SX2 too and I tried the mapping https://github.com/tildearrow/Mixxx-Pioneer-DDJ-SX2 and it does work pretty well. The color of the hot cue works as expected if you select the Serato colors in the Mixxx settings. and thewheel animation does work for me without issues it seems. the only issue with this binding is the reversed Tempo "fader", there is an issue on the repo for that. It would be awesome if the binding was included with Mixxx by default!

Thank you!

@Swiftb0y
Copy link
Member

Hey there @Krafting,
We'd love to have that mapping in mixxx, but they need to go through our review process. We have a Wiki Page on that. On first impression, the mapping unfortunately needs a little bit of work until it satisfies our standards. Nevertheless, you'd still be very welcome to contribute it via a Pull request. Are you interested in working on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants