simple RGB, HSV & Filtered waveforms not scrolling on macOS

[mixxxbot]

Reported by: foss-4
Date: 2021-05-18T09:48:13Z
Status: Confirmed
Importance: Medium
Launchpad Issue: lp1928772
Attachments: [waveform macOS issue.gif](https://bugs.launchpad.net/bugs/1928772/+attachment/5498444/+files/waveform macOS issue.gif)

---

2.3-beta-4017-g82dc1a70f1
macOS 11.3.1

Waveform is not scrolling as expected in some skins.

Deere: Waveform not loaded or shown at all
LateNight > PaleMoon: ok
Shade: ok
Tango: waveform not loaded. Strangely waveform loads once mouse hovers over waveform preview in deck. And more weirdness: waveform will not scroll - it does scroll however whenver the mouse pointer is moved over the wavefrom preview in deck.

---

Update
affected renderers: Filtered, HSV, RGB
affected skins: Deere + LateNight + Tango
all renderers work in Shade skin

[mixxxbot]

Commented by: foss-4
Date: 2021-05-18T09:48:13Z
Attachments: [waveform macOS issue.gif](https://bugs.launchpad.net/mixxx/+bug/1928772/+attachment/5498444/+files/waveform macOS issue.gif)

[mixxxbot]

Commented by: ronso0
Date: 2021-05-18T19:28:57Z

---

Can you please test with Deere and Tango which renderers are affected?

[mixxxbot]

Commented by: foss-4
Date: 2021-05-18T20:25:21Z

---

Deere:
affected: Filtered, HSV, RGB,
ok: Simple - Qt (GL), Filtered - Qt (GL), Simple (GL), Filtered (GL), Filtered (GLSL), RGB (GL), RGB (GLSL), HSV - Qt (GL) ping overlay with pink waveform - that expected? but it scrolls, RGB Qt (GL)

Tango:
affected: Filtered, HSV, RGB,
ok: Simple - Qt (GL), Filtered - Qt (GL), Simple (GL), Filtered (GL), Filtered (GLSL), RGB (GL), RGB (GLSL), HSV - Qt (GL) ping overlay with pink waveform - that expected? but it scrolls, RGB Qt (GL)

[mixxxbot]

Commented by: foss-4
Date: 2021-05-18T20:28:53Z

---

Deere + LateNight + Tango:
affected: Filtered, HSV, RGB,
ok: Simple - Qt (GL), Filtered - Qt (GL), Simple (GL), Filtered (GL), Filtered (GLSL), RGB (GL), RGB (GLSL), HSV - Qt (GL) ping overlay with pink waveform - that expected? but it scrolls, RGB Qt (GL)

Shade:
all waveforms ok

[mixxxbot]

Commented by: ronso0
Date: 2021-05-23T00:27:17Z

---

So now all skins except Shade are affected???

[mixxxbot]

Commented by: ronso0
Date: 2021-06-04T21:57:14Z

---

@Foss-4
Can you still reproduce this?
Or was there a mac update maybe?

[mixxxbot]

Commented by: foss-4
Date: 2021-06-05T07:55:04Z

---

2.3-beta-4131-g5ae08b96de on macOS 11.4 persisting.

[mixxxbot]

Commented by: ronso0
Date: 2021-06-10T15:26:27Z

---

This is kind of being wokred around already since the default waveform renderers are not affected, and when Mixxx crashes during skin because an affected renderer is selected that wouldn't be stored in the config, so it can at least be restarted without issues.

First I thought that might be caused by waveforms being loaded in Singletons, but that's not the case for affected LateNight (and not necessary in Tango btw).
Then we had Deere previously crashing on macOS if spinnies and waveforms were in the same singleton. But that's also been changed.
Back then, one conclusion was that reparenting the singleton caused issues with the GL context.

So it seems skins are affected as soon as ANY GL widget is loaded into a Singleton.
Solution would be to load individual instances of spinnies and waveforms in every skin, but that would defeat the purpose of saving memory only for getting the simple renderer to work on macOS.

Given the fact (assumption?) that the computers running the minimum supported macOS version 10.12 are powerful enough to not require the simple renderers for performance reasons we can simply hide them on macOS -- and switch to another renderer in case a simple renderer is stored in the config after upgrading to 2.3.

What do you think?

[mixxxbot]

Commented by: ywwg
Date: 2021-06-10T17:12:27Z

---

I agree, Apple laptops have had good GL for at least a decade, I can't imagine a situation where the fallbacks would be needed on that OS

[mixxxbot]

Commented by: ronso0
Date: 2021-06-10T18:40:06Z

---

oki, I'll prepare a PR

[mixxxbot]

Commented by: ronso0
Date: 2021-06-11T00:17:59Z

---

#3979

[mixxxbot]

Commented by: ronso0
Date: 2021-06-13T12:07:38Z

---

it's not fixed, just ignored and hidden for now ;)

[foss-]

Do we still need this issue?

After #3979 and #10989 I am not seeing any waveform issues.

macOS 13.4
Mixxx 2.4-alpha-1508-gb763121761 (HEAD)

[daschuer]

Thank you for confirming