Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing tempo when using instant double and sync #10550

Closed
mixxxbot opened this issue Aug 23, 2022 · 7 comments · Fixed by #12515
Closed

Changing tempo when using instant double and sync #10550

mixxxbot opened this issue Aug 23, 2022 · 7 comments · Fixed by #12515

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2021-10-07T17:58:08Z
Status: New
Importance: Undecided
Launchpad Issue: lp1946385


When using instant double and sync is enabled on the source and target deck, the tempo changes every time you repeat the instant double action.
The issue has been recorded here #3944 (comment)

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2021-10-08T02:02:44Z


The issue is that the sync occurs when the track is still seeked at position 0. A possible fix would be to create a way to load a track immediately seeked at the requested position. I don't think that should be too hard.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
@ronso0
Copy link
Member

ronso0 commented Aug 23, 2023

Is this still reproducible?

@daschuer
Copy link
Member

I can still reproduce the issue with 2.4-beta-96-g75833c0dba

There is also a flanger effect due to a micro offset when quantize is enabled and you instant-double a non const BPM track.
This does not happen every time, it is not reproducible without quantization enabled in the target deck.

Both issue cannot be reproduced with Mixxx 2.3.6

@m0dB
Copy link
Contributor

m0dB commented Sep 25, 2023

I ran into this issue some days ago but I have not been able to reproduce it since. The video in #3944 (comment) doesn't load for me. Is there a textual description of the exact steps to reproduce this?

@daschuer
Copy link
Member

  • Load a track with dynamic tempo to deck A
  • Sync Deck A + B
  • Make sure Deck A is leader
  • Dag and drop Track from Deck A to B

Expected results:
Deck A and B play perfectly synced, increasing the Volume by x2 (6 dB)
(This is the case without Sync)

Actual result:
Deck A applies tempo changes to Deck B resulting in a Flanger sound.

@ronso0
Copy link
Member

ronso0 commented Dec 20, 2023

For me the results is

  • both decks get synced to 120 BPM (internal clock default?) in the moment of dropping the track
  • deckA is slightly ahead (hence the flanger effect)
  • one click on temp_rate_down seems to fix it, at least waveforms seem to be in sync again and the flanger effect is not audible as such, but the stereo depth is gone, mix sounds flat so there IS still some offset

@daschuer
Copy link
Member

#12435 aims to fix these issues. Can you confirm this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants