Single effect chains not visible after first start in effects_refactoring branch

[mixxxbot]

Reported by: daschuer
Date: 2021-10-19T23:15:14Z
Status: Confirmed
Importance: Medium
Launchpad Issue: lp1947807

---

Single effect chains are created during the first start of Mixxx.
However they are not shown in the Effect preferences.
A restart of Mixxx fixes the issue.

The single effect chains should be visible instantly after start.

[mixxxbot]

Commented by: Be-ing
Date: 2021-10-20T14:03:40Z

---

What do you mean? Where are they not shown? Please post a screenshot.

[mixxxbot]

Commented by: Be-ing
Date: 2021-10-20T14:33:23Z

---

I cannot reproduce this after rm -rf ~/.mixxx/effects*

[mixxxbot]

Commented by: ronso0
Date: 2021-10-20T20:36:24Z

---

I'm not sure if this is what @dascher refers to, but I don't see a simple filter in the Quick Effect selector. This is a basic effect that should easy to pick, like flanger etc.
Restarting doesn't change that.
What am I missing?

[mixxxbot]

Commented by: ronso0
Date: 2021-10-20T20:38:39Z

---

Oh, they do show up after pressing Reset To Defaults, both in the preferences and in the selector in the skin.

[mixxxbot]

Commented by: Be-ing
Date: 2021-10-20T20:53:58Z

---

It's possible you have some weird state in ~/.mixxx/effects or ~/.mixxx/effects.xml from testing an earlier development version. Mixxx must not override the user's modified state with default settings unless the user presses Reset To Defaults in the preferences.

Please test again after running rm -r ~/.mixxx/effects*. If you can reproduce it, there is a bug.

[mixxxbot]

Commented by: ronso0
Date: 2021-10-20T21:03:40Z

---

I removed the effects folder for a clean start. 100% reproducible.
No simple effects listed, no effect loaded to the Quick Effect slots.

[mixxxbot]

Commented by: Be-ing
Date: 2021-10-20T21:16:13Z

---

Did you remove effects.xml too or just the effects directory?

[mixxxbot]

Commented by: ronso0
Date: 2021-10-20T22:01:40Z

---

true, the effects.xml needs to be removed, too. Thought that was the one from main.
Now effects are displayed correctly.

[mixxxbot]

Commented by: daschuer
Date: 2021-10-20T22:39:36Z

---

I have started Mixxx with a completely fresh preferences folder and I cannot longer reproduce the issue. So I think the issue is the same ronso0 describes.

[mixxxbot]

Commented by: Be-ing
Date: 2021-10-20T22:55:29Z

---

If the issue can be reproduced by upgrading settings from Mixxx 2.3 then there is a bug. Otherwise there is no problem.

[mixxxbot]

Commented by: daschuer
Date: 2021-10-21T22:22:05Z

---

Did you change something lately, that make the preset incompatible?
I have used the effect_refactoring branch here the first time two or three week ago. So it is unlikely that I have used an old version that creates the issue.

However I have switched between 2.3 main and this branch many times.

This will be the common case for many contributors after merge like rons0 so I do not longer consider this bug as invalid.

[mixxxbot]

Commented by: Be-ing
Date: 2021-10-21T23:06:37Z

---

The XML format for the presets has not been changed recently, at least not intentionally.

[mixxxbot]

Commented by: Be-ing
Date: 2021-10-22T21:04:52Z

---

I tested creating new settings directories with 2.3 then using it with effects_refactoring and could not reproduce this. I also could not reproduce it with a fresh settings directory created by the main branch.

[mixxxbot]

Commented by: daschuer
Date: 2021-10-22T22:55:01Z

---

It is normal in such cases that the original author is not able to reproduce it.

Ronso0 and I experienced the issue and when have no explaination why.
We also have no evidence that this cannot happen for another user.

Please reconsider your latest status change.

[mixxxbot]

Commented by: ronso0
Date: 2021-10-22T23:29:42Z

---

For me, the issue vanished when I also deleted effects.xml which I have been using for testing 2.3.x, various PRs targeting main as well as the effects_refactoring branch.

If we approach the issue from the other side:
what would prevent loading the simple effects?

[mixxxbot]

Commented by: daschuer
Date: 2021-10-23T00:18:01Z

---

Could it be caused by a previous debug assert crash?

What is the rule that creates these chains?
Is there a way to trick that rule?

[mixxxbot]

Commented by: Be-ing
Date: 2021-10-23T01:02:49Z

---

what would prevent loading the simple effects?

I presume you mean the autogenerated chain presets with a single effect. Those would not be added to the chain preset lists if effects.xml has a list that does not include them.

[mixxxbot]

Commented by: daschuer
Date: 2021-10-26T08:30:45Z

---

There is something fishy we need to investigate. I have set this to confirmed that it does not fall from the shelf.

[mixxxbot]

Commented by: Be-ing
Date: 2021-10-28T00:48:20Z

---

There is nothing to investigate if it cannot be reproduced.

[mixxxbot]

Commented by: daschuer
Date: 2021-10-28T06:05:59Z

---

We have two reports confirming the issue. This is sufficient to put a bug into a confirmed state.
It does not really sense to put a expiration timeout to the bug in this case.

There is nothing to investigate if it cannot be reproduced.

For my understanding the opposite is true, to deliver a rock solid software.
I understand that this Bug is probably not the most pressing issue, especially because it cannot be reproduced, but understanding the issue would help.
The bug is a reminder for this.

[ywwg]

@daschuer I understand your position here, but there have been a few instances where you'd prefer to keep a bug open that we cannot even reproduce. These bugs clutter up the bug system and make it hard to know what are even real problems and what was a one-time mistake. For cases like these, where years have gone by and nobody can reproduce the issue, we should close the bug. If, one day, someone finds this problem again, we can reopen the bug easily and we'll still have all of the discussion recorded. Closing this bug as non-reproducible until someone can come up with a predictable way to reproduce it.

[ywwg]

fixing status