Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect chain preferences: It is possible to select one effect in each column. #10572

Closed
mixxxbot opened this issue Aug 23, 2022 · 5 comments
Closed
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2021-10-20T22:56:17Z
Status: Fix Committed
Importance: Low
Launchpad Issue: lp1947921


When you select one effect in each column, it is no longer clear to which effetc chain the buttons are referring to.

Only one effect chain shall be select-able at all.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-10-22T00:17:37Z


I just hit a debug assert when I had a chain selected in each list and pressed reset to defaults

DEBUG ASSERT: "pModel" in function void DlgPrefEffects::effectsTableItemSelected(const QModelIndex&) at /src/preferences/dialog/dlgprefeffects.cpp:169

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-10-22T00:30:15Z


It's not caused by the chain selection:
select an effect in each of the lists in the Effects tab, hit either Reset.. or Cancel

debug assert fails

Pressing Okay closes the preferences but hit's the assert when I open the Preferences again.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-10-22T01:21:37Z


#4468

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-10-22T06:11:25Z


Thank you for taking care!
The debug assert is covered by https://bugs.launchpad.net/mixxx/+bug/1947615

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
@fwcd fwcd added the effects label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants