Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable search completions #10634

Closed
mixxxbot opened this issue Aug 23, 2022 · 4 comments · Fixed by #10942
Closed

Add option to disable search completions #10634

mixxxbot opened this issue Aug 23, 2022 · 4 comments · Fixed by #10942

Comments

@mixxxbot
Copy link
Collaborator

Reported by: fwcd
Date: 2022-01-04T21:42:30Z
Status: Confirmed
Importance: Low
Launchpad Issue: lp1956392
Tags: gui, library


It would be nice to have a setting for disabling the completions in the library search bar.

Version: 2.4.0-alpha-pre
Revision: bf1eef2

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-01-04T22:33:08Z


This sounds for like a workaround for a bug.

For be the completion kicks in to fast. Lets say I have searched for ABBA, next time I search for A, it is auto completed to ABBA and immediately applied. This means if I want to search for All tracks with A, I need to press del (which is not obvious to undo outo completion)

I like to have it more like in the browser address bar, where Enter is required to go to the auto completed Address. The "search as you type" should only be done for actual entered characters.

Will this solve your issue as well?

@mixxxbot
Copy link
Collaborator Author

Commented by: fwcd
Date: 2022-01-04T22:49:22Z


Yes, that is pretty much my use case too, but I would still appreciate the option to turn it off completely (just like most browsers support disabling various kinds of completions, private browsing etc.)

Ideally, the user could both hide/disable the completions in the settings and have some option to clear the history.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-01-04T23:12:34Z


I tested the auto-complete popup in #4505 and it does indeed improve the workflow. Right now it's styled by the system theme which is absolutey confusing. As soon as I work out how to use a dedicated QStyleDelegate we can add it back.

An option in Preferences > Library to turn off auto-completion entirely is also no big deal IMO (default: on), as well as a Clear History button

Search queries can already be removed one by one from the popup with Backspace and Del in 2.4 alpha.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
@ronso0 ronso0 changed the title Feature request: Option to disable search completions Add option to disable search completions Nov 21, 2022
@ronso0 ronso0 added feature and removed bug labels Nov 21, 2022
@ronso0
Copy link
Member

ronso0 commented Mar 24, 2023

Fixed by #10942

@ronso0 ronso0 closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants