Shader Waveforms have filled lead in/out

[daschuer]

Bug Description

Normally we have only the outlines of the triangles. With the GLSL types the triangles are filled. Not a real bug, but maybe it hides another issue:

Version

2.4-alpha

OS

Ubuntu

[daschuer]

@m0dB do you have an idea why this is the case?

[JoergAtGithub]

This is an intended visual improvement. We discussed this in the PR review and decided to keep it this way.

[m0dB]

To be fair, initially it was laziness, as drawing a filled triangle is much simpler than drawing only the outline. But I found I actually liked it much better, visually, so I kept it like this.

So, to put your mind at ease, @daschuer , it doesn't hide another issue.

[daschuer]

Ok thank you for confirm.

[Holzhaus]

IMHO waveforms should be consistent, so I'd like to keep this open until the other renders are adapted or the fill is removed.

[m0dB]

Since @Holzhaus insisted, but also because I thought of an approach that is much nicer implementation-wise (a single triangle drawn into an texture which is then repeated pattern-wise in the shader instead of in c++), I have fixed this is #12100

[m0dB]

@Holzhaus after some discussion, I went with a slightly different look then legacy, using a semi-transparent fill. So, not 100% "consistent" as you requested, but given the 50% transparency of the fill, and 100% match of the outline, I would say at least 50% consistent ;-)

Check out the PR for some screenshots.