Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test timed out: LoopInButton_QuantizeEnabledNoBeats #12588

Open
uklotzde opened this issue Jan 17, 2024 · 4 comments
Open

Test timed out: LoopInButton_QuantizeEnabledNoBeats #12588

uklotzde opened this issue Jan 17, 2024 · 4 comments
Labels

Comments

@uklotzde
Copy link
Contributor

uklotzde commented Jan 17, 2024

Bug Description

https://koji.rpmfusion.org/kojifiles/work/tasks/3696/623696/build.log

The following tests FAILED:
	434 - LoopingControlTest.LoopInButton_QuantizeEnabledNoBeats (Timeout)

Build task: https://koji.rpmfusion.org/koji/buildinfo?buildID=27603

Version

2.4.0

OS

Fedora 40

@uklotzde uklotzde added the bug label Jan 17, 2024
@uklotzde
Copy link
Contributor Author

I have disabled all LoopingControlTest to avoid future failures.

@ronso0
Copy link
Member

ronso0 commented Jan 19, 2024

maybe just a missing ProcessBuffer(); after

m_pButtonLoopIn->set(1);
m_pButtonLoopIn->set(0);

here

TEST_F(LoopingControlTest, LoopInButton_QuantizeEnabledNoBeats) {
m_pQuantizeEnabled->set(1);
m_pClosestBeat->set(-1);
m_pNextBeat->set(-1);
setCurrentPosition(mixxx::audio::FramePos{50});
m_pButtonLoopIn->set(1);
m_pButtonLoopIn->set(0);
EXPECT_FRAMEPOS_EQ_CONTROL(mixxx::audio::FramePos{50}, m_pLoopStartPoint);
}

?
Can that be tested without a PR/merge?

@daschuer
Copy link
Member

For my understanding a timeout happens when a call does not return for some reasons. All the calls in the test body should return immediately. So my guess is that something in the test setup got stuck or the test runner itself.

Was the time out a single instance or is it reproducible?

@uklotzde
Copy link
Contributor Author

For my understanding a timeout happens when a call does not return for some reasons. All the calls in the test body should return immediately. So my guess is that something in the test setup got stuck or the test runner itself.

Was the time out a single instance or is it reproducible?

Not reproducible. But likely a race condition in Mixxx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants