Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify setting hot cue inside a loop from the GUI #12618

Closed
mxmilkiib opened this issue Jan 22, 2024 · 4 comments · Fixed by #12623
Closed

simplify setting hot cue inside a loop from the GUI #12618

mxmilkiib opened this issue Jan 22, 2024 · 4 comments · Fixed by #12623

Comments

@mxmilkiib
Copy link
Contributor

mxmilkiib commented Jan 22, 2024

Bug Description

I don't think it's possible currently; creating one will make it be at the start of the loop as a loop;

image

Version

2.4-beta

@mxmilkiib mxmilkiib added the bug label Jan 22, 2024
@ronso0
Copy link
Member

ronso0 commented Jan 22, 2024

There are explicit hotcue_N_setcue controls for this purpose.

With the GUI this is indeed not possible right away.
You'd need to deactivate the loop, set the cue and reactivate the loop. Admittedly, in live situations this may be tricky with short loops.

Though, we may prohibit setting redundant hotcues at loop in.

@ronso0 ronso0 changed the title Create hot cue point inside a loop? simplify setting hot cue inside a loop from the GUI Jan 22, 2024
@Swiftb0y
Copy link
Member

Though, we may prohibit setting redundant hotcues at loop in.

I think that will cause opposition. People already use that strategy as a workaround for the fact that you can't jump to loopcues when you haven't passed the loop yet.

@ronso0
Copy link
Member

ronso0 commented Jan 22, 2024

Such a hotcue is set by seeking to the loop cue, deactivating the loop, triggering hotcue_X_activate.
That work(around) flow is not affected. See #12623

Clarification: don't (remotely) set a another identical loop cue at loop start when triggering hotcue_X_activate from another position inside an active loop.
And currently such a loop cue would be 100% identical since it adopts the active loop which was saved already.

@ronso0 ronso0 linked a pull request Jan 23, 2024 that will close this issue
@ronso0
Copy link
Member

ronso0 commented Jan 27, 2024

Fixed by #12623

@ronso0 ronso0 closed this as completed Jan 27, 2024
@ronso0 ronso0 added this to the 2.4.0 milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants