Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio drops when performing beatjump #13159

Open
acolombier opened this issue Apr 22, 2024 · 2 comments
Open

Audio drops when performing beatjump #13159

acolombier opened this issue Apr 22, 2024 · 2 comments
Labels

Comments

@acolombier
Copy link
Contributor

Bug Description

When performing large beatjumps (8+ beats), it happens sometimes that there is audio drops. I believe this is due to CachingReader miss, leading to delay to fetch the samples.
A suggestion would be to add Beatjump as a Hint::Type at playposition+beatjump size and playposition-beatjump size

Version

main

OS

Pop OS 22.04 (with Wayland)

@acolombier acolombier added the bug label Apr 22, 2024
@ronso0
Copy link
Member

ronso0 commented Apr 26, 2024

So you suggest to hint the reader with Hint::Type::Beatjump in LoopingControl::hintReader?
If I understand the flow correctly, this requires tracking the beatjump seek request or get it from EngineBuffer?

@acolombier
Copy link
Contributor Author

Yes, that's my suggestion, and from my understanding so far, this would indeed require tracking the beatjump seek request to add a hint at -/+ the current play position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants